From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH] ASoC: max98095: Convert codec->hw_write to snd_soc_write Date: Fri, 14 Oct 2011 20:03:42 +0100 Message-ID: <20111014190342.GA2931@opensource.wolfsonmicro.com> References: <1318563798.9296.1.camel@phoenix> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from opensource.wolfsonmicro.com (opensource.wolfsonmicro.com [80.75.67.52]) by alsa0.perex.cz (Postfix) with ESMTP id 0151824428 for ; Fri, 14 Oct 2011 21:03:45 +0200 (CEST) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Peter Hsiang Cc: Axel Lin , Liam Girdwood , "alsa-devel@alsa-project.org" , "linux-kernel@vger.kernel.org" List-Id: alsa-devel@alsa-project.org On Fri, Oct 14, 2011 at 10:40:58AM -0700, Peter Hsiang wrote: > On Fri, Oct 14, 2011, Axel Lin wrote: > > codec->hw_write is broken now, convert codec->hw_write to > > snd_soc_write. > The hardware has 2 banks of registers sharing a section in I2C register space. > The 1st bank is the primary one and is cached. > The 2nd bank is for loading coefficients only and they do not need cache. > These coefficients registers are therefore direct writes. > Changing this to a cached write will overwrite the cache. Writes to the cached region should be done within a cache_bypass flag to deal with this.