From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Ashish Chavan <ashish.chavan@kpitcummins.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
alsa-devel <alsa-devel@alsa-project.org>, lrg <lrg@ti.com>,
"kuninori.morimoto.gx" <kuninori.morimoto.gx@renesas.com>,
David Dajun Chen <david.chen@diasemi.com>
Subject: Re: [PATCH v3 2/8] ASoC: da7210: Add support for DAPM
Date: Fri, 14 Oct 2011 20:20:08 +0100 [thread overview]
Message-ID: <20111014192008.GD2931@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1318590098.12107.509.camel@matrix>
On Fri, Oct 14, 2011 at 04:31:38PM +0530, Ashish Chavan wrote:
> + /* ADCs */
> + SND_SOC_DAPM_ADC("ADC Left", "Capture", DA7210_STARTUP3, 5, 1),
> + SND_SOC_DAPM_ADC("ADC Right", "Capture", DA7210_STARTUP3, 6, 1),
> +
> + /* Output Side */
> + /* DACs */
> + SND_SOC_DAPM_DAC("DAC Left", "Playback", DA7210_STARTUP2, 5, 1),
> + SND_SOC_DAPM_DAC("DAC Right", "Playback", DA7210_STARTUP2, 6, 1),
These are also being enabled in the probe() function using completely
different registers - there the registers used are _ADC and _DAC.
What's going on there? It's good to see the stuff in the startup()
function gone but almost all of the probe() just shouldn't be there in a
properly written driver and much of it looks like stuff that DAPM should
be taking care of.
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Ashish Chavan <ashish.chavan@kpitcummins.com>
Cc: lrg <lrg@ti.com>, alsa-devel <alsa-devel@alsa-project.org>,
David Dajun Chen <david.chen@diasemi.com>,
"kuninori.morimoto.gx" <kuninori.morimoto.gx@renesas.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [alsa-devel] [PATCH v3 2/8] ASoC: da7210: Add support for DAPM
Date: Fri, 14 Oct 2011 20:20:08 +0100 [thread overview]
Message-ID: <20111014192008.GD2931@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1318590098.12107.509.camel@matrix>
On Fri, Oct 14, 2011 at 04:31:38PM +0530, Ashish Chavan wrote:
> + /* ADCs */
> + SND_SOC_DAPM_ADC("ADC Left", "Capture", DA7210_STARTUP3, 5, 1),
> + SND_SOC_DAPM_ADC("ADC Right", "Capture", DA7210_STARTUP3, 6, 1),
> +
> + /* Output Side */
> + /* DACs */
> + SND_SOC_DAPM_DAC("DAC Left", "Playback", DA7210_STARTUP2, 5, 1),
> + SND_SOC_DAPM_DAC("DAC Right", "Playback", DA7210_STARTUP2, 6, 1),
These are also being enabled in the probe() function using completely
different registers - there the registers used are _ADC and _DAC.
What's going on there? It's good to see the stuff in the startup()
function gone but almost all of the probe() just shouldn't be there in a
properly written driver and much of it looks like stuff that DAPM should
be taking care of.
next prev parent reply other threads:[~2011-10-14 19:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-14 11:01 [PATCH v3 2/8] ASoC: da7210: Add support for DAPM Ashish Chavan
2011-10-14 19:20 ` Mark Brown [this message]
2011-10-14 19:20 ` [alsa-devel] " Mark Brown
2011-10-15 8:20 ` Ashish Chavan
2011-10-17 21:41 ` Mark Brown
2011-10-17 21:41 ` [alsa-devel] " Mark Brown
2011-10-19 7:21 ` Ashish Chavan
2011-10-19 12:13 ` Mark Brown
2011-10-19 12:13 ` [alsa-devel] " Mark Brown
2011-10-20 11:47 ` Ashish Chavan
2011-10-20 12:36 ` [alsa-devel] " Mark Brown
2011-10-20 13:49 ` Ashish Chavan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111014192008.GD2931@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=ashish.chavan@kpitcummins.com \
--cc=david.chen@diasemi.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.