From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Frysinger Date: Sun, 16 Oct 2011 01:15:58 -0400 Subject: [U-Boot] [PATCH v2 2/2] Add a cli command to test the TPM device. In-Reply-To: References: <20111015033908.13FA4419FF@eskimo.mtv.corp.google.com> <201110151601.55979.vapier@gentoo.org> Message-ID: <201110160115.59515.vapier@gentoo.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Saturday 15 October 2011 16:27:02 Vadim Bendebury wrote: > On Sat, Oct 15, 2011 at 1:01 PM, Mike Frysinger wrote: > > On Saturday 15 October 2011 15:44:04 Wolfgang Denk wrote: > >> Vadim Bendebury wrote: > >> > > Two underscores aren't a good practice. > >> > > >> > I did this as a result of a previous review. Do you have a suggestion > >> > how this should be done instead? > >> > >> First, and most important, __u_boot_cmd_tpm appears to be undefined in > >> your two patches, so it looks to be a real bug. > >> > >> Second, please read the C standard's section about reserved > >> identifiers. > > > > no, this is coming from common u-boot code. look at > > include/command.h:U_BOOT_CMD defines. > > or, more importantly: the question is what is the right/suggested way > to print out the help message associated with a U_BOOT_CMD > declaration? your command is given a cmd_tbl_t *cmdtp pointer to pass to cmd_usage -mike -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: This is a digitally signed message part. Url : http://lists.denx.de/pipermail/u-boot/attachments/20111016/2ef767da/attachment.pgp