From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752363Ab1JPCl7 (ORCPT ); Sat, 15 Oct 2011 22:41:59 -0400 Received: from cantor2.suse.de ([195.135.220.15]:52512 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750760Ab1JPCl5 (ORCPT ); Sat, 15 Oct 2011 22:41:57 -0400 Date: Sat, 15 Oct 2011 19:39:43 -0700 From: Greg KH To: Yinghai Lu Cc: Jesse Barnes , "linux-pci@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 8/8] PCI, sys: only create rescan under /sys/.../pci/devices/... for pci bridges Message-ID: <20111016023943.GA3787@suse.de> References: <4E9A3092.4080309@oracle.com> <4E9A3436.3010704@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4E9A3436.3010704@oracle.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Oct 15, 2011 at 06:32:38PM -0700, Yinghai Lu wrote: > > Current code will create rescan for every pci device, > that is not right. the device is already there, there is no reason to rescan it. > > So only have rescan for pci bridges. less confusing > > Need to add cond to be new member of device_attribute. > device_add_attrs will check cond to see if need to create the attr. No, we already have a way to do this, this is not acceptable, sorry. greg k-h