From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marek.vasut@gmail.com>
Date: Sun, 16 Oct 2011 06:18:35 +0200
Subject: [U-Boot] [PATCH v3] NS16550: buffer reads
In-Reply-To: <CAPnjgZ1SRy=AAt556cefkovQpY-aGmz35WLyTuFQcUd+=6TRMw@mail.gmail.com>
References: <1318694632-21872-1-git-send-email-sjg@chromium.org>
	<201110151955.16625.marek.vasut@gmail.com>
	<CAPnjgZ1SRy=AAt556cefkovQpY-aGmz35WLyTuFQcUd+=6TRMw@mail.gmail.com>
Message-ID: <201110160618.35484.marek.vasut@gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Sunday, October 16, 2011 05:56:56 AM Simon Glass wrote:
> Hi Marek,
> 
> On Sat, Oct 15, 2011 at 10:55 AM, Marek Vasut <marek.vasut@gmail.com> wrote:
> > On Saturday, October 15, 2011 06:03:52 PM Simon Glass wrote:
> >> From: Scott Wood <scottwood@freescale.com>
> >> 
> >> From: Scott Wood <scottwood@freescale.com>
> >> 
> >> This improves the performance of U-Boot when accepting rapid input,
> >> such as pasting a sequence of commands.
> > 
> > Hi Simon,
> > 
> > [...]
> > 
> >> diff --git a/include/ns16550.h b/include/ns16550.h
> >> index 51f1c17..60b0abc 100644
> >> --- a/include/ns16550.h
> >> +++ b/include/ns16550.h
> >> @@ -164,6 +164,6 @@ typedef volatile struct NS16550 *NS16550_t;
> >> 
> >>  void NS16550_init   (NS16550_t com_port, int baud_divisor);
> >>  void NS16550_putc   (NS16550_t com_port, char c);
> >> -char NS16550_getc   (NS16550_t com_port);
> >> -int  NS16550_tstc   (NS16550_t com_port);
> >> +char NS16550_getc(NS16550_t regs, unsigned int port);
> >> +int NS16550_tstc(NS16550_t regs, unsigned int port);
> >>  void NS16550_reinit (NS16550_t com_port, int baud_divisor);
> > 
> > Maybe you should fix the indent altogether ?
> 
> I should probably do a separate patch for that.

Maybe queue it before this one ? :) Thanks!

> 
> Regards,
> Simon
> 
> > Cheers