From: Pete Wyckoff <pw@padd.com>
To: Stefano Lattarini <stefano.lattarini@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
Luke Diamand <luke@diamand.org>, Chris Li <git@chrisli.org>
Subject: Re: [PATCH 2/6] git-p4: handle utf16 filetype properly
Date: Sun, 16 Oct 2011 11:22:47 -0400 [thread overview]
Message-ID: <20111016152247.GA22954@arf.padd.com> (raw)
In-Reply-To: <201110161659.22261.stefano.lattarini@gmail.com>
stefano.lattarini@gmail.com wrote on Sun, 16 Oct 2011 16:59 +0200:
> Hi Pete, and thanks for taking my previous remarks into account. I have
> one more nit/question though ...
>
> On Sunday 16 October 2011, Pete Wyckoff wrote:
> > diff --git a/t/t9802-git-p4-filetype.sh b/t/t9802-git-p4-filetype.sh
> > new file mode 100755
> > index 0000000..dff0e02
> > --- /dev/null
> > +++ b/t/t9802-git-p4-filetype.sh
> > @@ -0,0 +1,108 @@
> > +#!/bin/sh
> > +
> > + [SNIP]
> > +
> > + printf "three\nline\ntext" >f-ascii &&
> >
> With this command, the `f-ascii' file won't be newline-terminated. Is
> this intended, or the result of an oversight? The same goes for further
> similar usages in the rest f the patch.
That is harmless. I think an earlier version used to count the
lines, but now it is just random text. Ditto the other places.
A trailing \n might be prettier, though, for some future debugging
of the tests. I tested that both with and without \n pass.
-- Pete
next prev parent reply other threads:[~2011-10-16 15:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-16 14:42 [PATCH v3 0/6] git-p4 tests, filetypes, shell metacharacters Pete Wyckoff
2011-10-16 14:43 ` [PATCH 1/6] git-p4 tests: refactor and cleanup Pete Wyckoff
2011-10-16 22:48 ` Pete Wyckoff
2011-10-16 14:44 ` [PATCH 2/6] git-p4: handle utf16 filetype properly Pete Wyckoff
2011-10-16 14:59 ` Stefano Lattarini
2011-10-16 15:22 ` Pete Wyckoff [this message]
2011-10-16 18:08 ` Junio C Hamano
2011-10-16 22:47 ` Pete Wyckoff
2011-10-16 14:45 ` [PATCH 3/6] git-p4: recognize all p4 filetypes Pete Wyckoff
2011-10-16 14:45 ` [PATCH 4/6] git-p4: stop ignoring apple filetype Pete Wyckoff
2011-10-16 14:46 ` [PATCH 5/6] git-p4: keyword flattening fixes Pete Wyckoff
2011-10-16 14:47 ` [PATCH 6/6] git-p4: handle files with shell metacharacters Pete Wyckoff
-- strict thread matches above, loose matches on Subject: below --
2011-10-15 15:53 [PATCH v2 0/6] git-p4 tests, filetypes, " Pete Wyckoff
2011-10-15 15:56 ` [PATCH 2/6] git-p4: handle utf16 filetype properly Pete Wyckoff
2011-10-16 9:52 ` Stefano Lattarini
2011-10-16 14:38 ` Pete Wyckoff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111016152247.GA22954@arf.padd.com \
--to=pw@padd.com \
--cc=git@chrisli.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=luke@diamand.org \
--cc=stefano.lattarini@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.