From: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
To: Jiri Slaby <jslaby@suse.cz>
Cc: gregkh@suse.de, linux-kernel@vger.kernel.org,
jirislaby@gmail.com, stable@kernel.org,
Sukadev Bhattiprolu <sukadev@us.ibm.com>,
Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: [PATCH 1/4] TTY: drop driver reference in tty_open fail path
Date: Sun, 16 Oct 2011 11:28:15 -0700 [thread overview]
Message-ID: <20111016182815.GA14883@us.ibm.com> (raw)
In-Reply-To: <1318411965-23917-1-git-send-email-jslaby@suse.cz>
Jiri Slaby [jslaby@suse.cz] wrote:
| When tty_driver_lookup_tty fails in tty_open, we forget to drop a
| reference to the tty driver. This was added by commit 4a2b5fddd5 (Move
| tty lookup/reopen to caller).
|
| Fix that by adding tty_driver_kref_put to the fail path.
Arg. Sorry about that. Thanks for spotting/fixing it.
|
| I will refactor the code later. This is for the ease of backporting to
| stable.
|
| Introduced-in: v2.6.28-rc2
| Signed-off-by: Jiri Slaby <jslaby@suse.cz>
| Cc: stable@kernel.org
| Cc: Sukadev Bhattiprolu <sukadev@us.ibm.com>
| Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
| Cc: Greg Kroah-Hartman <gregkh@suse.de>
Acked-by: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
prev parent reply other threads:[~2011-10-16 18:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-04 20:05 NULL dereference in tty_open() Dan Carpenter
2011-10-05 14:22 ` NULL dereference in tty_open() [and other bugs there] Jiri Slaby
2011-10-12 9:32 ` [PATCH 1/4] TTY: drop driver reference in tty_open fail path Jiri Slaby
2011-10-12 9:32 ` [PATCH 2/4] TTY: make tty_add_file non-failing Jiri Slaby
2011-10-12 9:32 ` [PATCH 3/4] TTY: pty, release tty in all ptmx_open fail paths Jiri Slaby
2011-10-12 13:23 ` Arnd Bergmann
2011-10-12 9:32 ` [PATCH 4/4] TTY: call tty_driver_lookup_tty unconditionally Jiri Slaby
2011-10-12 20:59 ` Jiri Slaby
2011-10-16 19:20 ` Sukadev Bhattiprolu
2011-10-16 19:37 ` Jiri Slaby
2011-10-16 18:28 ` Sukadev Bhattiprolu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111016182815.GA14883@us.ibm.com \
--to=sukadev@linux.vnet.ibm.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=gregkh@suse.de \
--cc=jirislaby@gmail.com \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@kernel.org \
--cc=sukadev@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.