All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marek.vasut@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/5] pxa: convert pxa27x_udc to use read and write functions
Date: Mon, 17 Oct 2011 19:31:21 +0200	[thread overview]
Message-ID: <201110171931.22119.marek.vasut@gmail.com> (raw)
In-Reply-To: <1318864970-11608-3-git-send-email-sherbrec@cit-ec.uni-bielefeld.de>

On Monday, October 17, 2011 05:22:48 PM Stefan Herbrechtsmeier wrote:
> Signed-off-by: Stefan Herbrechtsmeier <sherbrec@cit-ec.uni-bielefeld.de>
> CC: Marek Vasut <marek.vasut@gmail.com>
> CC: Remy Bohmer  <linux@bohmer.net>
> ---

Hi Stefan,

this patch is awesome, I really need this one. But ...

Can you possibly convert the register definitions to struct based access ?

Like 

struct pxa_usb_regs {
u32 reg1;
u32 reg2;
...
};

and then use it in the functions :

type fn()
{
	struct pxa_usb_regs regs = (struct pxa_usb_regs)0x46000000;
...
	writel(val, &regs->reg1);
}

Thanks!!

  reply	other threads:[~2011-10-17 17:31 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-17 15:22 [U-Boot] [PATCH 1/5] pxa: fix usb host register mismatch Stefan Herbrechtsmeier
2011-10-17 15:22 ` [U-Boot] [PATCH 2/5] pxa: activate the first usb host port on pxa27x by default Stefan Herbrechtsmeier
2011-11-26 22:23   ` Remy Bohmer
2011-10-17 15:22 ` [U-Boot] [PATCH 3/5] pxa: convert pxa27x_udc to use read and write functions Stefan Herbrechtsmeier
2011-10-17 17:31   ` Marek Vasut [this message]
2011-10-18 10:53     ` Stefan Herbrechtsmeier
2011-11-26 22:25     ` Remy Bohmer
2011-12-19 11:00   ` [U-Boot] [PATCH] drivers/usb/gadget/pxa27x_udc.c: Coding Style cleanup Wolfgang Denk
2011-12-19 11:34     ` Wolfgang Denk
2011-10-17 15:22 ` [U-Boot] [PATCH 4/5] usbtty: init endpoints prior to startup events Stefan Herbrechtsmeier
2011-11-26 22:25   ` Remy Bohmer
2011-11-28 10:05     ` Stefan Herbrechtsmeier
2011-11-30 21:21       ` Remy Bohmer
2011-12-02 12:12         ` Stefan Herbrechtsmeier
2011-10-17 15:22 ` [U-Boot] [PATCH 5/5] pxa: fix relocation Stefan Herbrechtsmeier
2011-11-26 22:27   ` Remy Bohmer
2011-11-28  9:35     ` Stefan Herbrechtsmeier
2011-11-26 22:23 ` [U-Boot] [PATCH 1/5] pxa: fix usb host register mismatch Remy Bohmer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201110171931.22119.marek.vasut@gmail.com \
    --to=marek.vasut@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.