From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Axel Lin <axel.lin@gmail.com>
Cc: Dimitris Papastamos <dp@opensource.wolfsonmicro.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
Liam Girdwood <lrg@ti.com>
Subject: Re: [PATCH 2/2] ASoC: wm9081: Use snd_soc_update_bits for read-modify-write
Date: Tue, 18 Oct 2011 00:25:47 +0100 [thread overview]
Message-ID: <20111017232547.GB2559@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1318826212.12989.2.camel@phoenix>
On Mon, Oct 17, 2011 at 12:36:52PM +0800, Axel Lin wrote:
> Use snd_soc_update_bits for read-modify-write register access instead of
> open-coding it using snd_soc_read and snd_soc_write
Something in here is breaking audio through the WM9081 on Speyside. I
can't immediately spot anything wrong but the behaviour is quite obvious
in the system.
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Dimitris Papastamos <dp@opensource.wolfsonmicro.com>,
Liam Girdwood <lrg@ti.com>,
alsa-devel@alsa-project.org
Subject: Re: [PATCH 2/2] ASoC: wm9081: Use snd_soc_update_bits for read-modify-write
Date: Tue, 18 Oct 2011 00:25:47 +0100 [thread overview]
Message-ID: <20111017232547.GB2559@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1318826212.12989.2.camel@phoenix>
On Mon, Oct 17, 2011 at 12:36:52PM +0800, Axel Lin wrote:
> Use snd_soc_update_bits for read-modify-write register access instead of
> open-coding it using snd_soc_read and snd_soc_write
Something in here is breaking audio through the WM9081 on Speyside. I
can't immediately spot anything wrong but the behaviour is quite obvious
in the system.
next prev parent reply other threads:[~2011-10-17 23:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-17 4:34 [PATCH 1/2] ASoC: wm9081: Fix setting soft VMID ramp enable with VMID 2*240k Axel Lin
2011-10-17 4:36 ` [PATCH 2/2] ASoC: wm9081: Use snd_soc_update_bits for read-modify-write Axel Lin
2011-10-17 4:36 ` Axel Lin
2011-10-17 23:25 ` Mark Brown [this message]
2011-10-17 23:25 ` Mark Brown
2011-10-18 1:43 ` Axel Lin
2011-10-18 1:43 ` Axel Lin
2011-10-17 23:22 ` [PATCH 1/2] ASoC: wm9081: Fix setting soft VMID ramp enable with VMID 2*240k Mark Brown
2011-10-17 23:22 ` Mark Brown
2011-10-20 1:50 ` Axel Lin
2011-10-20 12:37 ` Mark Brown
2011-10-20 12:37 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111017232547.GB2559@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=axel.lin@gmail.com \
--cc=dp@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.