From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: linux-nfs-owner@vger.kernel.org Received: from mga09.intel.com ([134.134.136.24]:29427 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756809Ab1JRIxz (ORCPT ); Tue, 18 Oct 2011 04:53:55 -0400 Date: Tue, 18 Oct 2011 16:53:51 +0800 From: Wu Fengguang To: Trond Myklebust , linux-nfs@vger.kernel.org Cc: Peter Zijlstra , "linux-fsdevel@vger.kernel.org" , Andrew Morton , Jan Kara , Christoph Hellwig , Dave Chinner , Greg Thelen , Minchan Kim , Vivek Goyal , Andrea Righi , linux-mm , LKML Subject: Re: [RFC][PATCH 2/2] nfs: scale writeback threshold proportional to dirty threshold Message-ID: <20111018085351.GB27805@localhost> References: <20111003134228.090592370@intel.com> <1318248846.14400.21.camel@laptop> <20111010130722.GA11387@localhost> <20111010131051.GA16847@localhost> <20111010131154.GB16847@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20111010131154.GB16847@localhost> Sender: linux-nfs-owner@vger.kernel.org List-ID: An update from Feng: Subject: nfs: fix a bug about adjusting nfs_congestion_kb Date: Tue Oct 18 12:47:58 CST 2011 From: "Tang, Feng" The VM dirty_thresh may be set to very small(even 0) by wired user, in such case, nfs_congestion_kb may be adjusted to 0, will cause the normal NFS write function get congested and deaklocked. So let's set the bottom line of nfs_congestion_kb to 128kb. Signed-off-by: Feng Tang Signed-off-by: Wu Fengguang --- fs/nfs/write.c | 1 + 1 file changed, 1 insertion(+) --- linux-next.orig/fs/nfs/write.c 2011-10-17 16:07:40.000000000 +0800 +++ linux-next/fs/nfs/write.c 2011-10-18 12:47:46.000000000 +0800 @@ -1814,6 +1814,7 @@ void nfs_update_congestion_thresh(void) */ global_dirty_limits(&background_thresh, &dirty_thresh); dirty_thresh <<= PAGE_SHIFT - 10; + dirty_thresh += 1024; if (nfs_congestion_kb > dirty_thresh / 8) nfs_congestion_kb = dirty_thresh / 8; From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wu Fengguang Subject: Re: [RFC][PATCH 2/2] nfs: scale writeback threshold proportional to dirty threshold Date: Tue, 18 Oct 2011 16:53:51 +0800 Message-ID: <20111018085351.GB27805@localhost> References: <20111003134228.090592370@intel.com> <1318248846.14400.21.camel@laptop> <20111010130722.GA11387@localhost> <20111010131051.GA16847@localhost> <20111010131154.GB16847@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Peter Zijlstra , "linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Andrew Morton , Jan Kara , Christoph Hellwig , Dave Chinner , Greg Thelen , Minchan Kim , Vivek Goyal , Andrea Righi , linux-mm , LKML To: Trond Myklebust , linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Return-path: Content-Disposition: inline In-Reply-To: <20111010131154.GB16847@localhost> Sender: linux-nfs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-fsdevel.vger.kernel.org An update from Feng: Subject: nfs: fix a bug about adjusting nfs_congestion_kb Date: Tue Oct 18 12:47:58 CST 2011 From: "Tang, Feng" The VM dirty_thresh may be set to very small(even 0) by wired user, in such case, nfs_congestion_kb may be adjusted to 0, will cause the normal NFS write function get congested and deaklocked. So let's set the bottom line of nfs_congestion_kb to 128kb. Signed-off-by: Feng Tang Signed-off-by: Wu Fengguang --- fs/nfs/write.c | 1 + 1 file changed, 1 insertion(+) --- linux-next.orig/fs/nfs/write.c 2011-10-17 16:07:40.000000000 +0800 +++ linux-next/fs/nfs/write.c 2011-10-18 12:47:46.000000000 +0800 @@ -1814,6 +1814,7 @@ void nfs_update_congestion_thresh(void) */ global_dirty_limits(&background_thresh, &dirty_thresh); dirty_thresh <<= PAGE_SHIFT - 10; + dirty_thresh += 1024; if (nfs_congestion_kb > dirty_thresh / 8) nfs_congestion_kb = dirty_thresh / 8; -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail6.bemta7.messagelabs.com (mail6.bemta7.messagelabs.com [216.82.255.55]) by kanga.kvack.org (Postfix) with ESMTP id 6D2F76B002F for ; Tue, 18 Oct 2011 04:54:08 -0400 (EDT) Date: Tue, 18 Oct 2011 16:53:51 +0800 From: Wu Fengguang Subject: Re: [RFC][PATCH 2/2] nfs: scale writeback threshold proportional to dirty threshold Message-ID: <20111018085351.GB27805@localhost> References: <20111003134228.090592370@intel.com> <1318248846.14400.21.camel@laptop> <20111010130722.GA11387@localhost> <20111010131051.GA16847@localhost> <20111010131154.GB16847@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20111010131154.GB16847@localhost> Sender: owner-linux-mm@kvack.org List-ID: To: Trond Myklebust , linux-nfs@vger.kernel.org Cc: Peter Zijlstra , "linux-fsdevel@vger.kernel.org" , Andrew Morton , Jan Kara , Christoph Hellwig , Dave Chinner , Greg Thelen , Minchan Kim , Vivek Goyal , Andrea Righi , linux-mm , LKML An update from Feng: Subject: nfs: fix a bug about adjusting nfs_congestion_kb Date: Tue Oct 18 12:47:58 CST 2011 From: "Tang, Feng" The VM dirty_thresh may be set to very small(even 0) by wired user, in such case, nfs_congestion_kb may be adjusted to 0, will cause the normal NFS write function get congested and deaklocked. So let's set the bottom line of nfs_congestion_kb to 128kb. Signed-off-by: Feng Tang Signed-off-by: Wu Fengguang --- fs/nfs/write.c | 1 + 1 file changed, 1 insertion(+) --- linux-next.orig/fs/nfs/write.c 2011-10-17 16:07:40.000000000 +0800 +++ linux-next/fs/nfs/write.c 2011-10-18 12:47:46.000000000 +0800 @@ -1814,6 +1814,7 @@ void nfs_update_congestion_thresh(void) */ global_dirty_limits(&background_thresh, &dirty_thresh); dirty_thresh <<= PAGE_SHIFT - 10; + dirty_thresh += 1024; if (nfs_congestion_kb > dirty_thresh / 8) nfs_congestion_kb = dirty_thresh / 8; -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org