From: Anatolij Gustschin <agust@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V2 2/2] api: export LCD and video to external apps
Date: Tue, 18 Oct 2011 09:17:50 +0200 [thread overview]
Message-ID: <20111018091750.70b0be74@wker> (raw)
In-Reply-To: <CANJuy2KTivzo_K1pjiK2gTgU4E2uL0E7ntMu-PyHk-0zLexXgA@mail.gmail.com>
Hi,
On Tue, 18 Oct 2011 14:12:59 +0800
Che-liang Chiou <clchiou@chromium.org> wrote:
...
> > Many boards defining CONFIG_LCD also define CONFIG_LCD_LOGO.
> > Enabling CONFIG_API for such board configurations will break
> > compiling, e.g.:
> >
> > $ ./MAKEALL TQM823L_LCD
> > Configuring for TQM823L_LCD - Board: TQM823L, Options: LCD,NEC_NL6448BC20
> > api_display.c: In function 'display_get_info':
> > api_display.c:40: error: 'BMP_LOGO_HEIGHT' undeclared (first use in this function)
> > api_display.c:40: error: (Each undeclared identifier is reported only once
> > api_display.c:40: error: for each function it appears in.)
> > make[1]: *** [api_display.o] Error 1
> > make: *** [api/libapi.o] Error 2
> >
> > Any idea how to fix this issue?
> >
>
> BMP_LOGO_HEIGHT is defined bmp_logo.h, which is automatically
> generated by tools/bmp_logo.c when CONFIG_LCD_LOGO or
> CONFIG_VIDEO_LOGO is set. So I guess this is quite easy to fix. We
> could include bmp_logo.h in api_display.c.
This won't work I'm afraid. bmp_logo.h is included elsewhere an including
it in libapi will cause multiple definition of `bmp_logo_bitmap' and
`bmp_logo_palette' compile errors.
Thanks,
Anatolij
next prev parent reply other threads:[~2011-10-18 7:17 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-04 8:16 [U-Boot] [PATCH 0/2] api: export LCD and video to external apps Che-Liang Chiou
2011-10-04 8:16 ` [U-Boot] [PATCH 1/2] lcd: video: add clear and draw bitmap declaration Che-Liang Chiou
2011-10-06 18:34 ` Wolfgang Denk
2011-10-04 8:16 ` [U-Boot] [PATCH 2/2] api: export LCD and video to external apps Che-Liang Chiou
2011-10-06 18:33 ` Wolfgang Denk
2011-10-07 8:32 ` Che-liang Chiou
2011-10-07 9:05 ` Wolfgang Denk
2011-10-07 9:45 ` Che-liang Chiou
2011-10-09 20:00 ` Wolfgang Denk
2011-10-07 8:28 ` [U-Boot] [PATCH V2 0/2] " Che-Liang Chiou
2011-10-07 8:28 ` [U-Boot] [PATCH V2 1/2] lcd: video: add clear and draw bitmap declaration Che-Liang Chiou
2011-10-07 8:28 ` [U-Boot] [PATCH V2 2/2] api: export LCD and video to external apps Che-Liang Chiou
2011-10-17 21:13 ` Anatolij Gustschin
2011-10-18 6:12 ` Che-liang Chiou
2011-10-18 7:17 ` Anatolij Gustschin [this message]
2011-10-18 8:24 ` Che-liang Chiou
2011-10-18 9:15 ` [U-Boot] [PATCH V3 0/4] " Che-Liang Chiou
2011-10-18 9:15 ` [U-Boot] [PATCH V3 1/4] lcd: video: add clear and draw bitmap declaration Che-Liang Chiou
2011-10-18 9:15 ` [U-Boot] [PATCH V3 2/4] tools: logo: add static and unused to bmp arrays Che-Liang Chiou
2011-10-18 9:15 ` [U-Boot] [PATCH V3 3/4] video: add access to GraphicDevice struct Che-Liang Chiou
2011-10-19 8:27 ` Anatolij Gustschin
2011-10-18 9:15 ` [U-Boot] [PATCH V3 4/4] api: export LCD and video to external apps Che-Liang Chiou
2011-10-19 8:56 ` Anatolij Gustschin
2011-10-20 5:41 ` Che-liang Chiou
2011-10-20 5:38 ` [U-Boot] [PATCH V4 0/3] " Che-Liang Chiou
2011-10-20 5:38 ` [U-Boot] [PATCH V4 1/3] lcd: add clear and draw bitmap declaration Che-Liang Chiou
2011-10-20 12:38 ` Mike Frysinger
2011-10-20 5:38 ` [U-Boot] [PATCH V4 2/3] tools: logo: add static and unused to bmp arrays Che-Liang Chiou
2011-10-20 12:42 ` Mike Frysinger
2011-10-20 18:43 ` Wolfgang Denk
2011-10-20 5:38 ` [U-Boot] [PATCH V4 3/3] api: export LCD device to external apps Che-Liang Chiou
2011-10-20 13:25 ` Mike Frysinger
2011-10-21 9:04 ` [U-Boot] [PATCH V5 0/4] " Che-Liang Chiou
2011-10-21 9:04 ` [U-Boot] [PATCH V5 1/4] lcd: add clear and draw bitmap declaration Che-Liang Chiou
2011-10-30 15:16 ` Mike Frysinger
2011-10-30 18:21 ` [U-Boot] [PATCH v6 " Anatolij Gustschin
2011-11-10 22:31 ` Anatolij Gustschin
2011-10-21 9:04 ` [U-Boot] [PATCH V5 2/4] tools: logo: split bmp arrays from bmp_logo.h Che-Liang Chiou
2011-10-30 15:24 ` Mike Frysinger
2011-10-30 18:24 ` [U-Boot] [PATCH v6 " Anatolij Gustschin
2011-11-10 22:33 ` Anatolij Gustschin
2011-10-21 9:04 ` [U-Boot] [PATCH V5 3/4] font: split font data from video_font.h Che-Liang Chiou
2011-10-30 15:36 ` Mike Frysinger
2011-10-30 18:33 ` Anatolij Gustschin
2011-10-31 2:23 ` Che-liang Chiou
2011-11-10 22:36 ` Anatolij Gustschin
2011-10-21 9:04 ` [U-Boot] [PATCH V5 4/4] api: export LCD device to external apps Che-Liang Chiou
2011-11-10 22:41 ` Anatolij Gustschin
2011-10-21 9:07 ` [U-Boot] [PATCH V5 1/4] lcd: add clear and draw bitmap declaration Che-Liang Chiou
2011-10-30 15:37 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111018091750.70b0be74@wker \
--to=agust@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.