From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] regulator: max8649 Convert max8649 to user regmap api
Date: Tue, 18 Oct 2011 13:30:22 +0100 [thread overview]
Message-ID: <20111018123022.GB28501@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <CAN1soZywkpvcoXOHHwob=UnHwwEebBFAmCZVN18AH8uzX=q0wg@mail.gmail.com>
On Tue, Oct 18, 2011 at 05:58:57PM +0800, Haojian Zhuang wrote:
> On Tue, Oct 18, 2011 at 3:23 PM, <jhbird.choi@samsung.com> wrote:
> > From: Jonghwan Choi <jhbird.choi@samsung.com>
> Comments?
There's not really much more to say than the changelog TBH.
> > +static struct regmap_config max8649_regmap_config = {
> > + ? ? ? .reg_bits = 8,
> > + ? ? ? .val_bits = 8,
> > +};
> > +
> Register CHIP_ID1 & CHIP_ID2 are only readable. But it isn't mentioned
> in your code.
This is optional unless the device is using the cache code, especially
given that not even max_register has been provided. For a conversion
like this providing access information is not needed.
prev parent reply other threads:[~2011-10-18 12:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-18 7:23 [PATCH] regulator: max8649 Convert max8649 to user regmap api jhbird.choi at samsung.com
2011-10-18 9:58 ` Haojian Zhuang
2011-10-18 12:30 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111018123022.GB28501@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.