From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] gpio: Add PCA9698 40-bit I2C I/O port
Date: Tue, 18 Oct 2011 16:23:07 +0200 [thread overview]
Message-ID: <201110181623.07484.sr@denx.de> (raw)
In-Reply-To: <1317719635-2792-1-git-send-email-eibach@gdsys.de>
Hi Dirk,
On Tuesday 04 October 2011 11:13:51 eibach at gdsys.de wrote:
> From: Dirk Eibach <eibach@gdsys.de>
Checkpatch output:
ERROR: memset size is 3rd argument, not the second.
#239: FILE: drivers/gpio/pca9698.c:120:
+ memset(data, sizeof(data), 0);
total: 1 errors, 0 warnings, 139 lines checked
So, this now really is a good checkpatch feature. I wasn't ware, that it
checked for such bugs as well. Nice. :)
Please fix and resubmit.
Thanks,
Stefan
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de
next prev parent reply other threads:[~2011-10-18 14:23 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-04 9:13 [U-Boot] [PATCH] gpio: Add PCA9698 40-bit I2C I/O port eibach at gdsys.de
2011-10-04 9:13 ` [U-Boot] [PATCH] ppc4xx: Do not stop booting on any keypress on intip eibach at gdsys.de
2011-10-12 9:49 ` Stefan Roese
2011-10-04 9:13 ` [U-Boot] [PATCH] ppc4xx: Improve lm63 pwm on dlvision-10g eibach at gdsys.de
2011-10-12 9:50 ` Stefan Roese
2011-10-04 9:13 ` [U-Boot] [PATCH] ppc4xx: Add Io64 board support eibach at gdsys.de
2011-10-06 21:09 ` Wolfgang Denk
2011-10-06 21:10 ` Wolfgang Denk
2011-10-04 9:13 ` [U-Boot] [PATCH] ppc4xx: Change DDR2 CL from 4 to 5 for intip eibach at gdsys.de
2011-10-12 9:50 ` Stefan Roese
2011-10-18 14:23 ` Stefan Roese [this message]
2011-10-21 22:43 ` [U-Boot] [PATCH] gpio: Add PCA9698 40-bit I2C I/O port Wolfgang Denk
-- strict thread matches above, loose matches on Subject: below --
2011-10-20 9:12 Dirk Eibach
2011-10-20 9:31 ` Stefan Roese
2011-10-20 9:40 ` Eibach, Dirk
2011-10-23 19:01 ` Wolfgang Denk
2011-10-26 6:44 ` Eibach, Dirk
2011-10-28 6:25 ` Stefan Roese
2011-10-28 20:14 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201110181623.07484.sr@denx.de \
--to=sr@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.