From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Konrad Rzeszutek Wilk <konrad@darnok.org>,
Jeremy Fitzhardinge <jeremy@goop.org>
Cc: Maxim Uvarov <maxim.uvarov@oracle.com>,
Jeremy Fitzhardinge <jeremy@goop.org>,
xen-devel@lists.xensource.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] XEN_DOMAIN_MEMORY options.
Date: Wed, 19 Oct 2011 10:04:06 -0400 [thread overview]
Message-ID: <20111019140406.GB7313@phenom.dumpdata.com> (raw)
In-Reply-To: <20111015130552.GC18864@andromeda.dapyr.net>
> > >>>What's the rationale?
> > >>>
> > >>> J
> > >>
> > >>The first patch is actually bug fix. You can not define just "int"
> > >>without description in Kconfig. As the result this option will not be
> > >>visible in menuconfig. Even if you will change it in .config make
> > >>oldconfig will set it up for default value. So you need to add any
> > >>description to it as all others int options have.
> > >
> > >No, that was deliberate, because I don't really think there's a need to
> > >change it.
> > >
> >
> > From that point of view it's not clear why this option is still in Kconfig?
>
> Well, we do need to alter it to 512GB. Actually - putting that extra
> burden on initial pagetables to reserve extra 384 pages might be a bit
> too much. Even thought later on we reclaim it if we do not use it.
Jeremy, without that change, you cannot specify
CONFIG_XEN_MAX_DOMAIN_MEMORY=512
if the distro desires to do so. Well, you can write it in the .config,
but the moment you compile, the oldconfig rewrites it to 128.
WARNING: multiple messages have this Message-ID (diff)
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Konrad Rzeszutek Wilk <konrad@darnok.org>
Cc: Maxim Uvarov <maxim.uvarov@oracle.com>,
Jeremy Fitzhardinge <jeremy@goop.org>,
xen-devel@lists.xensource.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] XEN_DOMAIN_MEMORY options.
Date: Wed, 19 Oct 2011 10:04:06 -0400 [thread overview]
Message-ID: <20111019140406.GB7313@phenom.dumpdata.com> (raw)
In-Reply-To: <20111015130552.GC18864@andromeda.dapyr.net>
> > >>>What's the rationale?
> > >>>
> > >>> J
> > >>
> > >>The first patch is actually bug fix. You can not define just "int"
> > >>without description in Kconfig. As the result this option will not be
> > >>visible in menuconfig. Even if you will change it in .config make
> > >>oldconfig will set it up for default value. So you need to add any
> > >>description to it as all others int options have.
> > >
> > >No, that was deliberate, because I don't really think there's a need to
> > >change it.
> > >
> >
> > From that point of view it's not clear why this option is still in Kconfig?
>
> Well, we do need to alter it to 512GB. Actually - putting that extra
> burden on initial pagetables to reserve extra 384 pages might be a bit
> too much. Even thought later on we reclaim it if we do not use it.
Jeremy, without that change, you cannot specify
CONFIG_XEN_MAX_DOMAIN_MEMORY=512
if the distro desires to do so. Well, you can write it in the .config,
but the moment you compile, the oldconfig rewrites it to 128.
next prev parent reply other threads:[~2011-10-19 14:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-14 22:36 [PATCH] XEN_DOMAIN_MEMORY options Maxim Uvarov
2011-10-14 22:36 ` [PATCH 1/2] xen: Fix XEN_MAX_DOMAIN_MEMORY to be selectable Maxim Uvarov
2011-10-14 22:36 ` [PATCH 2/2] xen: Make XEN_MAX_DOMAIN_MEMORY have more sensible defaults for 32-bit builds Maxim Uvarov
2011-10-14 23:00 ` [PATCH] XEN_DOMAIN_MEMORY options Jeremy Fitzhardinge
2011-10-14 23:33 ` Maxim Uvarov
2011-10-14 23:41 ` Jeremy Fitzhardinge
2011-10-15 0:43 ` Maxim Uvarov
2011-10-15 13:05 ` Konrad Rzeszutek Wilk
2011-10-15 16:42 ` Ian Campbell
2011-10-19 14:05 ` [Xen-devel] " Konrad Rzeszutek Wilk
2011-10-19 14:04 ` Konrad Rzeszutek Wilk [this message]
2011-10-19 14:04 ` Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111019140406.GB7313@phenom.dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=jeremy@goop.org \
--cc=konrad@darnok.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxim.uvarov@oracle.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.