From: Flavio Leitner <fbl@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: dpmcgee@gmail.com, netdev@vger.kernel.org, kuznet@ms2.inr.ac.ru,
jmorris@namei.org, yoshfuji@linux-ipv6.org, kaber@trash.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Disable TCP_DEBUG and FASTRETRANS_DEBUG by default
Date: Wed, 19 Oct 2011 15:16:00 -0200 [thread overview]
Message-ID: <20111019151600.67cd99e6@asterix.rh> (raw)
In-Reply-To: <20111017.175238.18474279385644215.davem@davemloft.net>
On Mon, 17 Oct 2011 17:52:38 -0400 (EDT)
David Miller <davem@davemloft.net> wrote:
> From: Dan McGee <dpmcgee@gmail.com>
> Date: Mon, 17 Oct 2011 15:25:24 -0500
>
> > If these are truly debug options, they should be turned off by default
> > and can be tweaked if necessary. Fix one usage of the flag to use #if
> > instead of #ifdef so defining to zero is acceptable.
> >
> > Signed-off-by: Dan McGee <dpmcgee@gmail.com>
>
> Illegal window shrinks are a serious issue, and the fact that everyone
> will see those messages by default and sometimes report them has been
> tremendously useful.
>
Agreed. I recently got bug report because of that message. It is useful
and doesn't disturbe when network is fine, so please don't remove it.
fbl
next prev parent reply other threads:[~2011-10-19 17:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-17 20:25 [PATCH] Disable TCP_DEBUG and FASTRETRANS_DEBUG by default Dan McGee
2011-10-17 21:52 ` David Miller
2011-10-19 17:16 ` Flavio Leitner [this message]
2011-10-22 1:54 ` Dan McGee
2011-10-24 18:15 ` [PATCH] TCP: remove TCP_DEBUG Flavio Leitner
2011-10-24 21:35 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111019151600.67cd99e6@asterix.rh \
--to=fbl@redhat.com \
--cc=davem@davemloft.net \
--cc=dpmcgee@gmail.com \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.