All of lore.kernel.org
 help / color / mirror / Atom feed
diff for duplicates of <20111019163816.GC2264@ericsson.com>

diff --git a/a/1.txt b/N1/1.txt
index 25f176f..2a5bd5c 100644
--- a/a/1.txt
+++ b/N1/1.txt
@@ -100,8 +100,7 @@ Should probably also depend on HWMON
 > +{
 > +	long result;
 > +	int val, ret, scaleint, scalepart;
-> +	struct sensor_device_attribute *sattr =
-> +		to_sensor_dev_attr(attr);
+> +	struct sensor_device_attribute *sattr > +		to_sensor_dev_attr(attr);
 
 Does this need more than one line ?
 
@@ -166,7 +165,7 @@ There should be blanks around '/' (why doesn't checkpatch complain about this an
 > +	int in_i = 1, temp_i = 1, curr_i = 1;
 > +
 > +	st = kzalloc(sizeof(*st), GFP_KERNEL);
-> +	if (st == NULL) {
+> +	if (st = NULL) {
 > +		ret = -ENOMEM;
 > +		goto error_ret;
 > +	}
@@ -184,10 +183,10 @@ There should be blanks around '/' (why doesn't checkpatch complain about this an
 > +	st->attrs = kzalloc(sizeof(st->attrs)*(i+1), GFP_KERNEL);
 
 Blanks around '*' and '+'.
-i == 0 here, so what is the point, and what are you trying to do ?
+i = 0 here, so what is the point, and what are you trying to do ?
 Should it be st->num_channels instead of i + 1 ?
 
-> +	if (st->attrs == NULL) {
+> +	if (st->attrs = NULL) {
 > +		ret = -ENOMEM;
 > +		goto error_release_channels;
 > +	}
@@ -217,7 +216,7 @@ What if this fails ?
 > +			ret = -EINVAL;
 > +			goto error_free_attrs;
 > +		}
-> +		if (a->dev_attr.attr.name == NULL) {
+> +		if (a->dev_attr.attr.name = NULL) {
 > +			ret = -ENOMEM;
 > +			goto error_free_attrs;
 > +		}
@@ -305,3 +304,8 @@ This doesn't unregister the hwmon device.
 Guenter Roeck
 Distinguished Engineer
 PDU IP Systems
+
+_______________________________________________
+lm-sensors mailing list
+lm-sensors@lm-sensors.org
+http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
diff --git a/a/content_digest b/N1/content_digest
index ab80737..d325f60 100644
--- a/a/content_digest
+++ b/N1/content_digest
@@ -1,8 +1,8 @@
  "ref\01319035628-32580-1-git-send-email-jic23@cam.ac.uk\0"
  "ref\01319035628-32580-6-git-send-email-jic23@cam.ac.uk\0"
  "From\0Guenter Roeck <guenter.roeck@ericsson.com>\0"
- "Subject\0Re: [PATCH 5/6] IIO:hwmon interface client driver.\0"
- "Date\0Wed, 19 Oct 2011 09:38:16 -0700\0"
+ "Subject\0Re: [lm-sensors] [PATCH 5/6] IIO:hwmon interface client driver.\0"
+ "Date\0Wed, 19 Oct 2011 16:38:16 +0000\0"
  "To\0Jonathan Cameron <jic23@cam.ac.uk>\0"
  "Cc\0linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org>"
   linux-iio@vger.kernel.org <linux-iio@vger.kernel.org>
@@ -118,8 +118,7 @@
  "> +{\n"
  "> +\tlong result;\n"
  "> +\tint val, ret, scaleint, scalepart;\n"
- "> +\tstruct sensor_device_attribute *sattr =\n"
- "> +\t\tto_sensor_dev_attr(attr);\n"
+ "> +\tstruct sensor_device_attribute *sattr > +\t\tto_sensor_dev_attr(attr);\n"
  "\n"
  "Does this need more than one line ?\n"
  "\n"
@@ -184,7 +183,7 @@
  "> +\tint in_i = 1, temp_i = 1, curr_i = 1;\n"
  "> +\n"
  "> +\tst = kzalloc(sizeof(*st), GFP_KERNEL);\n"
- "> +\tif (st == NULL) {\n"
+ "> +\tif (st = NULL) {\n"
  "> +\t\tret = -ENOMEM;\n"
  "> +\t\tgoto error_ret;\n"
  "> +\t}\n"
@@ -202,10 +201,10 @@
  "> +\tst->attrs = kzalloc(sizeof(st->attrs)*(i+1), GFP_KERNEL);\n"
  "\n"
  "Blanks around '*' and '+'.\n"
- "i == 0 here, so what is the point, and what are you trying to do ?\n"
+ "i = 0 here, so what is the point, and what are you trying to do ?\n"
  "Should it be st->num_channels instead of i + 1 ?\n"
  "\n"
- "> +\tif (st->attrs == NULL) {\n"
+ "> +\tif (st->attrs = NULL) {\n"
  "> +\t\tret = -ENOMEM;\n"
  "> +\t\tgoto error_release_channels;\n"
  "> +\t}\n"
@@ -235,7 +234,7 @@
  "> +\t\t\tret = -EINVAL;\n"
  "> +\t\t\tgoto error_free_attrs;\n"
  "> +\t\t}\n"
- "> +\t\tif (a->dev_attr.attr.name == NULL) {\n"
+ "> +\t\tif (a->dev_attr.attr.name = NULL) {\n"
  "> +\t\t\tret = -ENOMEM;\n"
  "> +\t\t\tgoto error_free_attrs;\n"
  "> +\t\t}\n"
@@ -322,6 +321,11 @@
  "-- \n"
  "Guenter Roeck\n"
  "Distinguished Engineer\n"
- PDU IP Systems
+ "PDU IP Systems\n"
+ "\n"
+ "_______________________________________________\n"
+ "lm-sensors mailing list\n"
+ "lm-sensors@lm-sensors.org\n"
+ http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
 
-3ec9d74c121764c255b25d69edda319fa6c7e558ce0180c670d9d263469291cf
+944d9ca379131bf19d3c33d6a1f7ce44de157d512c46225b0beff928546785b6

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.