All of lore.kernel.org
 help / color / mirror / Atom feed
From: "J. Bruce Fields" <bfields@fieldses.org>
To: Steve Dickson <SteveD@redhat.com>
Cc: Jeff Layton <jlayton@redhat.com>,
	Linux NFS Mailing list <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH 1/1] mount.nfs: mtab corruption when RLIMIT_FSIZE causes a partial write
Date: Wed, 19 Oct 2011 16:01:43 -0400	[thread overview]
Message-ID: <20111019200143.GB805@fieldses.org> (raw)
In-Reply-To: <4E9F2C5F.8080103@RedHat.com>

On Wed, Oct 19, 2011 at 04:00:31PM -0400, Steve Dickson wrote:
> 
> 
> On 10/19/2011 03:55 PM, J. Bruce Fields wrote:
> > On Wed, Oct 19, 2011 at 02:38:49PM -0400, Steve Dickson wrote:
> >> This is the case. The following patch cause SIGXFSZ to be ignored.
> >>
> >> diff -up ./utils/mount/fstab.c.orig ./utils/mount/fstab.c
> >> --- ./utils/mount/fstab.c.orig	2011-10-19 13:28:57.318132000 -0400
> >> +++ ./utils/mount/fstab.c	2011-10-19 14:02:07.715039000 -0400
> >> @@ -387,8 +387,9 @@ lock_mtab (void) {
> >>  		sa.sa_flags = 0;
> >>  		sigfillset (&sa.sa_mask);
> >>    
> >> -		while (sigismember (&sa.sa_mask, ++sig) != -1
> >> -		       && sig != SIGCHLD) {
> > 
> > I'm very confused--the latest nfs-utils doesn't have this.
> > 
> > Oh, I see: it was fixed by b3e190c4adfc9ec47567c968bd000d282d07b05e
> > "mount: improve signal management when locking mtab".
> > 
> > So if you're working with an older version then you probably want to
> > backport that patch.
> Exactly... Read my last posting...  

I'm way behind!  Thanks--b.

  reply	other threads:[~2011-10-19 20:01 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-19 15:34 [PATCH 1/1] mount.nfs: mtab corruption when RLIMIT_FSIZE causes a partial write Steve Dickson
2011-10-19 16:36 ` Jeff Layton
2011-10-19 17:10   ` Steve Dickson
2011-10-19 17:22     ` Jeff Layton
2011-10-19 17:30       ` Steve Dickson
2011-10-19 17:36         ` J. Bruce Fields
2011-10-19 18:38           ` Steve Dickson
2011-10-19 19:55             ` J. Bruce Fields
2011-10-19 20:00               ` Steve Dickson
2011-10-19 20:01                 ` J. Bruce Fields [this message]
2011-10-19 17:40         ` Jeff Layton
2011-10-19 18:00           ` Steve Dickson
2011-10-19 17:28     ` J. Bruce Fields
2011-10-19 17:32       ` Steve Dickson
2011-10-19 17:39         ` J. Bruce Fields
2011-10-19 19:44 ` Steve Dickson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111019200143.GB805@fieldses.org \
    --to=bfields@fieldses.org \
    --cc=SteveD@redhat.com \
    --cc=jlayton@redhat.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.