From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1 of 5] Makefile.package.in: add utility functions find*clauses and notfirstword
Date: Thu, 20 Oct 2011 00:32:56 +0200 [thread overview]
Message-ID: <201110200032.56871.arnout@mind.be> (raw)
In-Reply-To: <31ae7a6eaff4e2cf9a1e.1318602116@devws108>
On Wednesday 19 October 2011 09:34:04, Thomas De Schampheleire wrote:
> +# findfileclauses_cont: creates "-o -name 'X' -o -name 'Y'"
> +# [1:namelist, 2:prefix]
> +findfileclauses_cont=$(patsubst %,$(2) -name '%',$(1))
> +# findfileclauses: creates "-name 'X' -o -name 'Y'"
> +# [1:namelist]
> +findfileclauses=$(call findfileclauses_cont,$(firstword $(1))) $(call findfileclauses_cont,$(call notfirstword,$(1)),-o)
The _cont function is a bit redundant, no?
findfileclauses=-name '$(firstword $(1))' $(patsubst %,-o -name '%',$(call notfirstword,$(1)))
I don't think the duplication of -name warrants the additional function
call. It definitely doesn't make it easier to understand.
Nevertheless, this is a nifty patch!
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286540
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 31BB CF53 8660 6F88 345D 54CC A836 5879 20D7 CF43
next prev parent reply other threads:[~2011-10-19 22:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-19 7:33 [Buildroot] [PATCH 0 of 5] Add find utility functions / exclude files from strip / reduce python Thomas De Schampheleire
2011-10-19 7:34 ` [Buildroot] [PATCH 1 of 5] Makefile.package.in: add utility functions find*clauses and notfirstword Thomas De Schampheleire
2011-10-19 22:32 ` Arnout Vandecappelle [this message]
2011-10-20 6:55 ` Thomas De Schampheleire
2011-10-19 7:34 ` [Buildroot] [PATCH 2 of 5] stripping: use findfileclauses utility function Thomas De Schampheleire
2011-10-19 7:34 ` [Buildroot] [PATCH 3 of 5] build: add option to exclude executables/dirs from being stripped Thomas De Schampheleire
2011-10-19 7:34 ` [Buildroot] [PATCH 4 of 5] python config: move configuration into menu Thomas De Schampheleire
2011-10-19 7:34 ` [Buildroot] [PATCH 5 of 5] python: allow reduced installation Thomas De Schampheleire
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201110200032.56871.arnout@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.