All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <htejun@gmail.com>
To: Gwendal Grignou <gwendal@google.com>
Cc: kernel@teksavvy.com, mihrcke@gmail.com, derry@high-rely.com,
	linux-ide@vger.kernel.org
Subject: Re: [PATCH] [libata]Issue SRST to Disks behind Sil3726
Date: Wed, 19 Oct 2011 17:37:20 -0700	[thread overview]
Message-ID: <20111020003720.GU25124@google.com> (raw)
In-Reply-To: <1319070953-24391-2-git-send-email-gwendal@google.com>

On Wed, Oct 19, 2011 at 05:35:53PM -0700, Gwendal Grignou wrote:
> Reenable sending SRST to devices connected behind a Sil3726 PMP.
> This allow staggered spinups and handles drives that spins up slowly.
> 
> While the drives spin up, the PMP will not accept SRST.
> Most controllers reissue the reset until the drive is ready, while
> some [Sil3124] returns an error.
> In ata_eh_error, wait for the next reset deadline before resetting the ATA
> port and trying again.
> 
> 
> Signed-off-by: Gwendal Grignou <gwendal@google.com>

 Acked-by: Tejun Heo <tj@kernel.org>

I hope this can be applied to other controllers too as the failure
mode should be similar for all SIMG PMPs.

Thanks.

-- 
tejun

  reply	other threads:[~2011-10-20  0:37 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <359604ECF8F440408B9634E6146249B42923805F@mail.scl.local>
     [not found] ` <20110628095723.GC3386@htj.dyndns.org>
2011-06-30 17:53   ` Problem w/ hotplug on sata_sil24 w/ PMP (sil3726) Derry Bryson
2011-07-12 15:01     ` tj
2011-07-12 19:21       ` Derry Bryson
2011-07-13 13:34         ` tj
2011-07-13 14:39           ` tj
2011-07-13 16:23             ` Derry Bryson
2011-07-14  7:14               ` tj
2011-07-14 17:37                 ` Derry Bryson
2011-07-21  9:00                   ` tj
2011-07-21 16:22                     ` Derry Bryson
2011-07-22  9:50                       ` tj
2011-07-22 17:29                         ` Derry Bryson
2011-07-22 19:34                         ` Derry Bryson
2011-07-30 12:54                           ` tj
2011-09-30 21:54                             ` Mike I
2011-10-06  5:48                               ` Gwendal Grignou
2011-10-06  6:03                                 ` [PATCH] libata: Allow SOFT_RESET for Sil3726 Gwendal Grignou
2011-10-06  8:03                                   ` Tejun Heo
2011-10-06 20:44                                     ` Gwendal Grignou
2011-10-06 22:10                                       ` Tejun Heo
2011-10-12 14:03                                         ` Mark Lord
2011-10-20  0:02                                           ` [PATCH] [libata]Issue SRST to Sil3726 PMP Gwendal Grignou
2011-10-20  0:02                                           ` Gwendal Grignou
2011-10-20  0:07                                             ` Tejun Heo
2011-10-20  0:28                                               ` Gwendal Grignou
2011-10-20  0:17                                           ` Gwendal Grignou
2011-10-20  0:17                                           ` Gwendal Grignou
2011-10-20  0:35                                           ` [PATCH] [libata]Send SRST to disks behind " Gwendal Grignou
2011-10-20  0:35                                           ` [PATCH] [libata]Issue SRST to Disks behind Sil3726 Gwendal Grignou
2011-10-20  0:37                                             ` Tejun Heo [this message]
2011-10-06 10:42                                   ` [PATCH] libata: Allow SOFT_RESET for Sil3726 Sergei Shtylyov
     [not found]                                 ` <CAMHSBOV8rSW3jumpx8URZrgo8w1He9zruP7yAOw7uhQOaAj3Xg@mail.gmail.com>
2011-10-06  6:07                                   ` Problem w/ hotplug on sata_sil24 w/ PMP (sil3726) Gwendal Grignou
2011-10-08 18:25                                 ` Michael Ihrcke
2011-10-12  2:06                                   ` Michael Ihrcke
2011-10-13  2:09                                     ` Mike I

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111020003720.GU25124@google.com \
    --to=htejun@gmail.com \
    --cc=derry@high-rely.com \
    --cc=gwendal@google.com \
    --cc=kernel@teksavvy.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=mihrcke@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.