diff for duplicates of <20111020091416.1e90828c@skate> diff --git a/a/1.txt b/N1/1.txt index a949b2c..247cc8f 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,5 +1,5 @@ Le Wed, 19 Oct 2011 18:18:54 +0200, -Maxime Ripard <maxime.ripard@free-electrons.com> a =C3=A9crit : +Maxime Ripard <maxime.ripard@free-electrons.com> a ?crit : > +void __init at91_add_device_adc(struct at91_adc_data *data) > +{ @@ -15,10 +15,10 @@ As suggested, the decision of which ADC channels are used and therefore which pins should be muxed to function A is a board-specific decision and should not be enforced by SoC code. -> +static struct at91_adc_data ek_adc_data =3D { -> + .channels =3D 4, -> + .adc_clock =3D 5000000, -> + .startup_time =3D 10, +> +static struct at91_adc_data ek_adc_data = { +> + .channels = 4, +> + .adc_clock = 5000000, +> + .startup_time = 10, > +}; And on the opposite, those informations are specific to a SoC, not to a @@ -45,15 +45,15 @@ at91_add_device_adc() { at91_set_A_periph(AT91_PIN_PC2, 0); if (data->channels_used[3]) at91_set_A_periph(AT91_PIN_PC3, 0); - data->startup_time =3D ... - data->channels =3D ... - data->adc_clock =3D ... + data->startup_time = ... + data->channels = ... + data->adc_clock = ... } and the board file would do: -struct at91_adc_data ek_adc_data =3D { - .channels_used =3D { 1, 0, 1, 1 },; +struct at91_adc_data ek_adc_data = { + .channels_used = { 1, 0, 1, 1 },; }; Or maybe others have different suggestions ? @@ -61,7 +61,7 @@ Or maybe others have different suggestions ? Regards, Thomas ---=20 +-- Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. diff --git a/a/content_digest b/N1/content_digest index 21730a1..a8851cd 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,17 +1,13 @@ "ref\01319041134-19712-1-git-send-email-maxime.ripard@free-electrons.com\0" "ref\01319041134-19712-4-git-send-email-maxime.ripard@free-electrons.com\0" - "From\0Thomas Petazzoni <thomas.petazzoni@free-electrons.com>\0" - "Subject\0Re: [PATCH 3/3] ARM: AT91: Add the ADC to the sam9g20ek board\0" + "From\0thomas.petazzoni@free-electrons.com (Thomas Petazzoni)\0" + "Subject\0[PATCH 3/3] ARM: AT91: Add the ADC to the sam9g20ek board\0" "Date\0Thu, 20 Oct 2011 09:14:16 +0200\0" - "To\0Maxime Ripard <maxime.ripard@free-electrons.com>\0" - "Cc\0linux-arm-kernel@lists.infradead.org" - linux-iio@vger.kernel.org - Patrice Vilchez <patrice.vilchez@atmel.com> - " Nicolas Ferre <nicolas.ferre@atmel.com>\0" + "To\0linux-arm-kernel@lists.infradead.org\0" "\00:1\0" "b\0" "Le Wed, 19 Oct 2011 18:18:54 +0200,\n" - "Maxime Ripard <maxime.ripard@free-electrons.com> a =C3=A9crit :\n" + "Maxime Ripard <maxime.ripard@free-electrons.com> a ?crit :\n" "\n" "> +void __init at91_add_device_adc(struct at91_adc_data *data)\n" "> +{\n" @@ -27,10 +23,10 @@ "which pins should be muxed to function A is a board-specific decision\n" "and should not be enforced by SoC code.\n" "\n" - "> +static struct at91_adc_data ek_adc_data =3D {\n" - "> +\t.channels =3D 4,\n" - "> +\t.adc_clock =3D 5000000,\n" - "> +\t.startup_time =3D 10,\n" + "> +static struct at91_adc_data ek_adc_data = {\n" + "> +\t.channels = 4,\n" + "> +\t.adc_clock = 5000000,\n" + "> +\t.startup_time = 10,\n" "> +};\n" "\n" "And on the opposite, those informations are specific to a SoC, not to a\n" @@ -57,15 +53,15 @@ "\t\tat91_set_A_periph(AT91_PIN_PC2, 0);\n" "\tif (data->channels_used[3])\n" "\t\tat91_set_A_periph(AT91_PIN_PC3, 0);\n" - "\tdata->startup_time =3D ...\n" - "\tdata->channels =3D ...\n" - "\tdata->adc_clock =3D ...\n" + "\tdata->startup_time = ...\n" + "\tdata->channels = ...\n" + "\tdata->adc_clock = ...\n" "}\n" "\n" "and the board file would do:\n" "\n" - "struct at91_adc_data ek_adc_data =3D {\n" - "\t.channels_used =3D { 1, 0, 1, 1 },;\n" + "struct at91_adc_data ek_adc_data = {\n" + "\t.channels_used = { 1, 0, 1, 1 },;\n" "};\n" "\n" "Or maybe others have different suggestions ?\n" @@ -73,10 +69,10 @@ "Regards,\n" "\n" "Thomas\n" - "--=20\n" + "-- \n" "Thomas Petazzoni, Free Electrons\n" "Kernel, drivers, real-time and embedded Linux\n" "development, consulting, training and support.\n" http://free-electrons.com -aebc2351003d381057052b47de0c57dcc11088973ca6bccaca996046355af507 +56706eb0e7ec59ca12015980eb0f8a384c54f2713a420f68bf9a6671a5e58b6c
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.