From: "bfields@fieldses.org" <bfields@fieldses.org>
To: Stanislav Kinsbursky <skinsbursky@parallels.com>
Cc: "Trond.Myklebust@netapp.com" <Trond.Myklebust@netapp.com>,
"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>,
Pavel Emelianov <xemul@parallels.com>,
"neilb@suse.de" <neilb@suse.de>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"devel@openvz.org" <devel@openvz.org>
Subject: Re: [RFC PATCH 0/5] SUNRPC: "RPC pipefs per network namespace" preparations
Date: Thu, 20 Oct 2011 08:32:42 -0400 [thread overview]
Message-ID: <20111020123242.GN5444@fieldses.org> (raw)
In-Reply-To: <4EA000C6.1040502@parallels.com>
On Thu, Oct 20, 2011 at 03:06:46PM +0400, Stanislav Kinsbursky wrote:
> Guys, please, spend some of your expensive time to review this patch-set briefly.
I'll try to take a look soon, but I'm travelling tomorrow through the
31st, and things will be a little hectic.
Just one quick comment:
> >The only problem about I'm not sure how to solve properly yet, is auth gss
> >pipes creations operations. Hoping for some help with it.
I suspect one reason it may be a little complicated is the
upcall-version switching. The old version is deprecated, and there's no
need to support the combination of the old version with the a new
feature like containers. And now that it's been there a while the
version-switching code already achieved its goal of avoiding a flag day.
So, one approach might be:
- move all the code for the old gss upcall and for the version
switching under a new CONFIG_DEPRECATED_GSS, or similar.
- print a warning if the old stuff is used, and plan to rip it
out completely in a future kernel version.
- do something that works just in the !CONFIG_DEPRECATED_GSS
case.
Would that help?
--b.
WARNING: multiple messages have this Message-ID (diff)
From: "bfields-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org" <bfields-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>
To: Stanislav Kinsbursky
<skinsbursky-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
Cc: "Trond.Myklebust-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org"
<Trond.Myklebust-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org>,
"linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Pavel Emelianov <xemul-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>,
"neilb-l3A5Bk7waGM@public.gmane.org"
<neilb-l3A5Bk7waGM@public.gmane.org>,
"netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org"
<davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>,
"devel-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org"
<devel-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org>
Subject: Re: [RFC PATCH 0/5] SUNRPC: "RPC pipefs per network namespace" preparations
Date: Thu, 20 Oct 2011 08:32:42 -0400 [thread overview]
Message-ID: <20111020123242.GN5444@fieldses.org> (raw)
In-Reply-To: <4EA000C6.1040502-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
On Thu, Oct 20, 2011 at 03:06:46PM +0400, Stanislav Kinsbursky wrote:
> Guys, please, spend some of your expensive time to review this patch-set briefly.
I'll try to take a look soon, but I'm travelling tomorrow through the
31st, and things will be a little hectic.
Just one quick comment:
> >The only problem about I'm not sure how to solve properly yet, is auth gss
> >pipes creations operations. Hoping for some help with it.
I suspect one reason it may be a little complicated is the
upcall-version switching. The old version is deprecated, and there's no
need to support the combination of the old version with the a new
feature like containers. And now that it's been there a while the
version-switching code already achieved its goal of avoiding a flag day.
So, one approach might be:
- move all the code for the old gss upcall and for the version
switching under a new CONFIG_DEPRECATED_GSS, or similar.
- print a warning if the old stuff is used, and plan to rip it
out completely in a future kernel version.
- do something that works just in the !CONFIG_DEPRECATED_GSS
case.
Would that help?
--b.
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-10-20 12:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-17 13:10 [RFC PATCH 0/5] SUNRPC: "RPC pipefs per network namespace" preparations Stanislav Kinsbursky
2011-10-17 13:10 ` [RFC PATCH 1/5] SUNRPC: hold current network namespace while pipefs superblock is active Stanislav Kinsbursky
2011-10-17 13:10 ` [RFC PATCH 2/5] SUNRPC: send notification events on pipefs sb creation and destruction Stanislav Kinsbursky
2011-10-17 13:10 ` [RFC PATCH 3/5] SUNRPC: pipefs dentry lookup helper introduced Stanislav Kinsbursky
2011-10-17 13:10 ` [RFC PATCH 4/5] SUNRPC: put pipefs superblock link on network namespace Stanislav Kinsbursky
2011-10-17 13:10 ` [RFC PATCH 5/5] SUNRPC: pipefs per-net operations helper introduced Stanislav Kinsbursky
2011-10-20 11:06 ` [RFC PATCH 0/5] SUNRPC: "RPC pipefs per network namespace" preparations Stanislav Kinsbursky
2011-10-20 12:32 ` bfields [this message]
2011-10-20 12:32 ` bfields-uC3wQj2KruNg9hUCZPvPmw
2011-10-20 12:56 ` Stanislav Kinsbursky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111020123242.GN5444@fieldses.org \
--to=bfields@fieldses.org \
--cc=Trond.Myklebust@netapp.com \
--cc=davem@davemloft.net \
--cc=devel@openvz.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=neilb@suse.de \
--cc=netdev@vger.kernel.org \
--cc=skinsbursky@parallels.com \
--cc=xemul@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.