From: Mike Frysinger <vapier@gentoo.org>
To: Kyle Moffett <Kyle.D.Moffett@boeing.com>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
Randy Dunlap <rdunlap@xenotime.net>,
Stephen Hemminger <shemminger@vyatta.com>,
"David S. Miller" <davem@davemloft.net>,
Greg Dietsche <Gregory.Dietsche@cuw.edu>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
David Daney <ddaney@caviumnetworks.com>,
Arnaud Patard <arnaud.patard@rtp-net.org>,
Grant Likely <grant.likely@secretlab.ca>,
Baruch Siach <baruch@tkos.co.il>,
Thorsten Schubert <tshu@msc-ge.com>,
David Decotigny <decot@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Lucas De Marchi <lucas.demarchi@profusion.mobi>,
"Marc Kleine-Budde" <mkl@pengutronix.de>,
linux-doc@vger.kernel.org
Subject: Re: [RFC PATCH 05/17] phy_driver: Make .read_status()/.config_aneg() optional
Date: Thu, 20 Oct 2011 17:14:31 -0400 [thread overview]
Message-ID: <201110201714.36533.vapier@gentoo.org> (raw)
In-Reply-To: <201110201710.17519.vapier@gentoo.org>
[-- Attachment #1: Type: Text/Plain, Size: 1601 bytes --]
On Thursday 20 October 2011 17:10:12 Mike Frysinger wrote:
> On Thursday 20 October 2011 17:00:12 Kyle Moffett wrote:
> > Approximately 90% of the PHY drivers follow the PHY layer docs and
> > simply use &genphy_read_status and &genphy_config_aneg. There would
> > seem to be little point in requiring them all to manually specify those
> > functions.
>
> well, it does make sense if you think about the compile vs build time
> overhead. yes, your patch does make things much nicer to read, and a
> little easier to maintain the source. however, it adds runtime overhead
> (checking the func pointers) while the func pointer storage is unchanged
> (it's now a NULL pointer instead of pointing to the genphy funcs).
> personally, i think the savings in runtime and smaller compiled code is
> more important. so i'm going to NAK this. sorry.
>
> > This patch makes it much easier for subsequent patches to split and
> > refactor the functionality of the .config_aneg() method.
> >
> > Signed-off-by: Kyle Moffett <Kyle.D.Moffett@boeing.com>
> > ---
> >
> > Documentation/networking/phy.txt | 13 +++++--------
> > drivers/net/phy/bcm63xx.c | 4 ----
>
> hrm, what tree are you using ? this driver is not in mainline.
ah, sorry, i was thinking this was u-boot since we were just having
conversations there.
since this is Linux, and i don't have real standing in the general netdev
community, i can't really NAK here. but i think my comment still stands in
that this patch makes things much worse than the minor code style improvement.
-mike
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2011-10-20 21:14 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-20 21:00 [RFC PATCH 0/17] Miscellaneous generic PHY layer improvements Kyle Moffett
2011-10-20 21:00 ` [RFC PATCH 01/17] et1011c: Replaced PHY driver by a small dm646x board fixup Kyle Moffett
2011-10-20 21:00 ` Kyle Moffett
2011-10-20 21:00 ` Kyle Moffett
2011-10-20 21:00 ` [RFC PATCH 02/17] of_mdio: Don't phy_scan_fixups() twice Kyle Moffett
2011-10-25 4:56 ` Grant Likely
2011-10-20 21:00 ` [RFC PATCH 03/17] greth: Allow PHYs to override ->read_status Kyle Moffett
2011-10-20 21:00 ` [RFC PATCH 04/17] phy/icplus: Fix read_status/config_aneg error handling Kyle Moffett
2011-10-20 21:00 ` [RFC PATCH 05/17] phy_driver: Make .read_status()/.config_aneg() optional Kyle Moffett
2011-10-20 21:10 ` Mike Frysinger
2011-10-20 21:14 ` Mike Frysinger [this message]
2011-10-21 5:13 ` Kyle Moffett
2011-10-25 7:06 ` Mike Frysinger
2011-10-20 21:00 ` [RFC PATCH 06/17] phy_driver: Add and use phy_driver_[un]register_multiple() Kyle Moffett
2011-10-20 21:15 ` Mike Frysinger
2011-10-25 5:00 ` Grant Likely
2011-10-25 5:41 ` Mike Frysinger
2011-11-03 22:46 ` Andy Fleming
2011-10-20 21:00 ` [RFC PATCH 07/17] phy: Unify PHY reset, initialization, and fixup handling Kyle Moffett
2011-10-20 21:00 ` [RFC PATCH 08/17] drivers/net/bfin_mac: Don't unnecessarily reset the PHY Kyle Moffett
2011-10-25 6:59 ` Mike Frysinger
2011-10-25 7:26 ` Zhang, Sonic
2011-10-20 21:00 ` [RFC PATCH 09/17] mv643xx_eth: Use standardized phy_init_hw() for PHY reset Kyle Moffett
2011-10-20 21:00 ` [RFC PATCH 10/17] pxa186_eth: " Kyle Moffett
2011-10-20 21:00 ` [RFC PATCH 11/17] sh_eth: Don't unnecessarily reset the PHY Kyle Moffett
2011-10-25 11:11 ` Yoshihiro Shimoda
2011-10-25 16:00 ` Moffett, Kyle D
2011-10-20 21:00 ` [RFC PATCH 12/17] tc35815: Use standard phy_init_hw() instead of BMCR_RESET bit Kyle Moffett
2011-10-20 21:00 ` [RFC PATCH 13/17] mpc836x: Move board-specific bcm5481 fixup out of the PHY driver Kyle Moffett
2011-10-20 21:00 ` Kyle Moffett
2011-10-20 21:00 ` [RFC PATCH 14/17] lxt973: Clean up fixed-mode fiber PHY handling Kyle Moffett
2011-10-20 21:00 ` [RFC PATCH 15/17] phy_device: Add "port" and "transciever" fields Kyle Moffett
2011-10-20 23:27 ` Ben Hutchings
2011-10-21 7:12 ` Kyle Moffett
2011-10-20 21:00 ` [RFC PATCH 16/17] phy_device: Add phy_setmask helper function Kyle Moffett
2011-10-20 21:00 ` [RFC PATCH 17/17] phy_device: Rename phy_start_aneg() to phy_start_link() Kyle Moffett
2011-10-20 21:00 ` Kyle Moffett
2011-11-03 22:51 ` Andy Fleming
2011-11-03 22:51 ` Andy Fleming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201110201714.36533.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=Gregory.Dietsche@cuw.edu \
--cc=Kyle.D.Moffett@boeing.com \
--cc=akpm@linux-foundation.org \
--cc=arnaud.patard@rtp-net.org \
--cc=baruch@tkos.co.il \
--cc=davem@davemloft.net \
--cc=ddaney@caviumnetworks.com \
--cc=decot@google.com \
--cc=grant.likely@secretlab.ca \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lucas.demarchi@profusion.mobi \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=rdunlap@xenotime.net \
--cc=shemminger@vyatta.com \
--cc=tshu@msc-ge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.