Re: [PATCH 5/6] Input: wacom - read 3rd gen Bamboo Touch HID data

[Dmitry Torokhov <dmitry.torokhov@gmail.com>]

On Sunday, October 16, 2011 06:29:40 PM chris@cnpbagwell.com wrote:
> From: Chris Bagwell <chris@cnpbagwell.com>
> 
> Signed-off-by: Chris Bagwell <chris@cnpbagwell.com>
> ---
>  drivers/input/tablet/wacom_sys.c |   48
> ++++++++++++++++++++++++++++++++++++- 1 files changed, 46
> insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/input/tablet/wacom_sys.c
> b/drivers/input/tablet/wacom_sys.c index 5e1539c..d19886a 100644
> --- a/drivers/input/tablet/wacom_sys.c
> +++ b/drivers/input/tablet/wacom_sys.c
> @@ -28,7 +28,9 @@
>  #define HID_USAGE_Y_TILT		0x3e
>  #define HID_USAGE_FINGER		0x22
>  #define HID_USAGE_STYLUS		0x20
> -#define HID_COLLECTION			0xc0
> +#define HID_COLLECTION			0xa1
> +#define HID_COLLECTION_LOGICAL		0x02
> +#define HID_COLLECTION_END		0xc0
> 
>  enum {
>  	WCM_UNDEFINED = 0,
> @@ -165,6 +167,34 @@ static void wacom_close(struct input_dev *dev)
>  		usb_autopm_put_interface(wacom->intf);
>  }
> 
> +static int wacom_parse_logical_collection(unsigned char *report,
> +					  struct wacom_features *features)
> +{
> +	int length = 0;
> +
> +	if (features->type == BAMBOO_PT) {
> +
> +		/* Logical collection is only used by 3rd gen Bamboo Touch */
> +		features->pktlen = WACOM_PKGLEN_BBTOUCH3;

Compile dies here because WACOM_PKGLEN_BBTOUCH3 is defined in the
next patch.

Please make sure the series is bisectable.

Thanks.

-- 
Dmitry