From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:52638) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RGyBI-0007ym-V0 for qemu-devel@nongnu.org; Thu, 20 Oct 2011 15:21:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RGyBE-0000fD-5F for qemu-devel@nongnu.org; Thu, 20 Oct 2011 15:21:32 -0400 Received: from mail-bw0-f45.google.com ([209.85.214.45]:45787) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RGyBD-0000ev-Lw for qemu-devel@nongnu.org; Thu, 20 Oct 2011 15:21:28 -0400 Received: by bkat2 with SMTP id t2so4251261bka.4 for ; Thu, 20 Oct 2011 12:21:26 -0700 (PDT) From: Max Filippov Date: Thu, 20 Oct 2011 23:20:54 +0400 MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <201110202320.54504.jcmvbkbc@gmail.com> Subject: [Qemu-devel] build with trace enabled is broken by the commit c572f23a3e7180dbeab5e86583e43ea2afed6271 hw/9pfs: Introduce tracing for 9p pdu handlers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Harsh Prateek Bora Cc: "Aneesh Kumar K.V" , qemu-devel@nongnu.org Hi. Current git head build with trace enabled is broken by the commit c572f23a3= e7180dbeab5e86583e43ea2afed6271 hw/9pfs: Introduce tracing for 9p pdu handl= ers. Error messages: In file included from trace.c:2:0: trace.h: In function =E2=80=98trace_v9fs_attach=E2=80=99: trace.h:2850:9: error: too many arguments for format [-Werror=3Dformat-extr= a-args] trace.h: In function =E2=80=98trace_v9fs_wstat=E2=80=99: trace.h:3039:9: error: too many arguments for format [-Werror=3Dformat-extr= a-args] trace.h: In function =E2=80=98trace_v9fs_mkdir=E2=80=99: trace.h:3088:9: error: too many arguments for format [-Werror=3Dformat-extr= a-args] trace.h: In function =E2=80=98trace_v9fs_mkdir_return=E2=80=99: trace.h:3095:9: error: too many arguments for format [-Werror=3Dformat-extr= a-args] cc1: all warnings being treated as errors Prototypes in the trace-events do not match format strings, e.g. v9fs_attach(uint16_t tag, uint8_t id, int32_t fid, int32_t afid, char* unam= e, char* aname) "tag %d id %d fid %d afid %d aname %s" The following patch fixes it, but I'm not sure the format lines are appropr= iate. diff --git a/trace-events b/trace-events index fc13733..d04fe3e 100644 =2D-- a/trace-events +++ b/trace-events @@ -557,7 +557,7 @@ open_eth_desc_write(uint32_t addr, uint32_t v) "DESC[%0= 4x] <- %08x" complete_pdu(uint16_t tag, uint8_t id, int err) "tag %d id %d err %d" v9fs_version(uint16_t tag, uint8_t id, int32_t msize, char* version) "tag = %d id %d msize %d version %s" v9fs_version_return(uint16_t tag, uint8_t id, int32_t msize, char* version= ) "tag %d id %d msize %d version %s" =2Dv9fs_attach(uint16_t tag, uint8_t id, int32_t fid, int32_t afid, char* u= name, char* aname) "tag %d id %d fid %d afid %d aname %s" +v9fs_attach(uint16_t tag, uint8_t id, int32_t fid, int32_t afid, char* una= me, char* aname) "tag %d id %d fid %d afid %d uname %s aname %s" v9fs_attach_return(uint16_t tag, uint8_t id, int8_t type, int32_t version,= int64_t path) "tag %d id %d type %d version %d path %"PRId64"" v9fs_stat(uint16_t tag, uint8_t id, int32_t fid) "tag %d id %d fid %d" v9fs_stat_return(uint16_t tag, uint8_t id, int32_t mode, int32_t atime, in= t32_t mtime, int64_t length) "tag %d id %d stat=3D{mode %d atime %d mtime %= d length %"PRId64"}" @@ -584,15 +584,15 @@ v9fs_symlink_return(uint16_t tag, uint8_t id, int8_t = type, int32_t version, int6 v9fs_flush(uint16_t tag, uint8_t id, int16_t flush_tag) "tag %d id %d flus= h_tag %d" v9fs_link(uint16_t tag, uint8_t id, int32_t dfid, int32_t oldfid, char* na= me) "tag %d id %d dfid %d oldfid %d name %s" v9fs_remove(uint16_t tag, uint8_t id, int32_t fid) "tag %d id %d fid %d" =2Dv9fs_wstat(uint16_t tag, uint8_t id, int32_t fid, int32_t mode, int32_t = atime, int32_t mtime) "tag %d id %d fid %d stat=3D{mode %d atime %d mtime}" +v9fs_wstat(uint16_t tag, uint8_t id, int32_t fid, int32_t mode, int32_t at= ime, int32_t mtime) "tag %d id %d fid %d stat=3D{mode %d atime %d mtime %d}" v9fs_mknod(uint16_t tag, uint8_t id, int32_t fid, int mode, int major, int= minor) "tag %d id %d fid %d mode %d major %d minor %d" v9fs_mknod_return(uint16_t tag, uint8_t id, int8_t type, int32_t version, = int64_t path) "tag %d id %d qid=3D{type %d version %d path %"PRId64"}" v9fs_lock(uint16_t tag, uint8_t id, int32_t fid, uint8_t type, uint64_t st= art, uint64_t length) "tag %d id %d fid %d type %d start %"PRIu64" length %= "PRIu64"" v9fs_lock_return(uint16_t tag, uint8_t id, int8_t status) "tag %d id %d st= atus %d" v9fs_getlock(uint16_t tag, uint8_t id, int32_t fid, uint8_t type, uint64_t= start, uint64_t length)"tag %d id %d fid %d type %d start %"PRIu64" length= %"PRIu64"" v9fs_getlock_return(uint16_t tag, uint8_t id, uint8_t type, uint64_t start= , uint64_t length, uint32_t proc_id) "tag %d id %d type %d start %"PRIu64" = length %"PRIu64" proc_id %u" =2Dv9fs_mkdir(uint16_t tag, uint8_t id, int32_t fid, char* name, int mode, = uint32_t gid) "tag %d id %d fid %d name %s mode %d" =2Dv9fs_mkdir_return(uint16_t tag, uint8_t id, int8_t type, int32_t version= , int64_t path, int err) "tag %d id %d qid=3D{type %d version %d path %"PRI= d64"}" +v9fs_mkdir(uint16_t tag, uint8_t id, int32_t fid, char* name, int mode, ui= nt32_t gid) "tag %d id %d fid %d name %s mode %d gid %d" +v9fs_mkdir_return(uint16_t tag, uint8_t id, int8_t type, int32_t version, = int64_t path, int err) "tag %d id %d qid=3D{type %d version %d path %"PRId6= 4"} err %d" v9fs_xattrwalk(uint16_t tag, uint8_t id, int32_t fid, int32_t newfid, char= * name) "tag %d id %d fid %d newfid %d name %s" v9fs_xattrwalk_return(uint16_t tag, uint8_t id, int64_t size) "tag %d id %= d size %"PRId64"" v9fs_xattrcreate(uint16_t tag, uint8_t id, int32_t fid, char* name, int64_= t size, int flags) "tag %d id %d fid %d name %s size %"PRId64" flags %d" Thanks. =2D- Max