From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/3] lsof: fix permission of extracted files
Date: Fri, 21 Oct 2011 08:55:40 +0200 [thread overview]
Message-ID: <20111021085540.666a392d@skate> (raw)
In-Reply-To: <1319148323-26856-1-git-send-email-damian@veritymedical.co.uk>
Le Fri, 21 Oct 2011 00:05:23 +0200,
Damian Kaczmarek <damian@veritymedical.co.uk> a ?crit :
> +LSOF_EXTRACT_CMDS = \
> + $(INFLATE.bz2) $(DL_DIR)/$(LSOF_SOURCE) | \
> + $(TAR) -O $(TAR_OPTIONS) - lsof_$(LSOF_VERSION)/lsof_$(LSOF_VERSION)_src.tar | \
> + $(TAR) $(TAR_STRIP_COMPONENTS)=1 -C $(LSOF_DIR) $(TAR_OPTIONS) -
I would prefer:
define LSOF_EXTRACT_CMDS
$(INFLATE.bz2) $(DL_DIR)/$(LSOF_SOURCE) | \
$(TAR) -O $(TAR_OPTIONS) - lsof_$(LSOF_VERSION)/lsof_$(LSOF_VERSION)_src.tar | \
$(TAR) $(TAR_STRIP_COMPONENTS)=1 -C $(LSOF_DIR) $(TAR_OPTIONS) -
endef
since this is what we use for all other pkg_something_CMDS.
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2011-10-21 6:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-20 22:05 [Buildroot] [PATCH 1/3] lsof: fix permission of extracted files Damian Kaczmarek
2011-10-21 6:55 ` Thomas Petazzoni [this message]
2011-10-21 16:21 ` Yann E. MORIN
2011-11-24 22:14 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111021085540.666a392d@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.