From: Jakub Narebski <jnareb@gmail.com>
To: "Lénaïc Huard" <lenaic@lhuard.fr.eu.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] gitweb: provide a way to customize html headers
Date: Fri, 21 Oct 2011 21:14:33 +0200 [thread overview]
Message-ID: <201110212114.34325.jnareb@gmail.com> (raw)
In-Reply-To: <201110210046.34679.lenaic@lhuard.fr.eu.org>
Dnia piątek 21. października 2011 00:46, Lénaïc Huard napisał:
> Le lundi 17 octobre 2011, Jakub Narebski a écrit :
>> On Mon, 17 Oct 2011, Lénaïc Huard wrote:
>>> Jakub Narebski <jnareb@gmail.com> writes:
>>>> Lénaïc Huard <lenaic@lhuard.fr.eu.org> writes:
[...]
>>>>> gitweb/INSTALL | 3 +++
>>>>
>>>> Nb. there is patch in flight adding gitweb.conf(5) and gitweb(1)
>>>> manpages...
>>>
>>> Ok. So, I’ll update them once a decision will be taken concerning this
>>> $site_htmlheader.
>>
>> You might have to wait a bit till patches containing gitweb.conf(5)
>> manpage are merged in, and rebase your patch to add information about
>> new config variable not to gitweb/INSTALL, but to
>> Documentation/gitweb.conf.txt
>
> I added the documentation to Documentation/gitweb.conf.txt.
> But, as I noticed that gitweb/INSTALL still exists and still documents the
> old variables, I left the doc of the new one.
>
> Documentation/gitweb.conf.txt | 5 +++++
> gitweb/INSTALL | 2 ++
> gitweb/Makefile | 2 ++
> gitweb/gitweb.perl | 7 +++++++
> t/gitweb-lib.sh | 1 +
> 5 files changed, 17 insertions(+), 0 deletions(-)
Well, gitweb/INSTALL documents _build_ time [make] variables, and that
didn't change with introduction of gitweb manpages. Those are important
only during explanation.
It is only runtime _configuration_ that moved from gitweb/README (which
should be short description of project) to manpages for gitweb config.
--
Jakub Narebski
Poland
next prev parent reply other threads:[~2011-10-21 19:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-17 7:28 [PATCH] gitweb: provide a way to customize html headers Lénaïc Huard
2011-10-17 11:56 ` Jakub Narebski
2011-10-20 22:46 ` Lénaïc Huard
2011-10-21 0:37 ` Junio C Hamano
2011-10-21 7:09 ` Lénaïc Huard
2011-10-21 19:14 ` Jakub Narebski [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-10-16 20:56 Lénaïc Huard
2011-10-16 21:26 ` Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201110212114.34325.jnareb@gmail.com \
--to=jnareb@gmail.com \
--cc=git@vger.kernel.org \
--cc=lenaic@lhuard.fr.eu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.