From: Jurij Smakov <jurij@wooyd.org>
To: sparclinux@vger.kernel.org
Subject: Re: longjmp question
Date: Sat, 22 Oct 2011 09:43:39 +0000 [thread overview]
Message-ID: <20111022094339.GA8547@wooyd.org> (raw)
In-Reply-To: <20111007232209.GA11892@wooyd.org>
On Sat, Oct 22, 2011 at 05:05:05AM -0400, David Miller wrote:
> From: Jurij Smakov <jurij@wooyd.org>
> Date: Sat, 22 Oct 2011 10:00:24 +0100
>
> > Is something conceptually wrong with just doing this:
> >
> > asm volatile ("save; flush; restore");
> >
> > It fixes the problem for freebsd (will test on linux later today), and
> > does not rely on compiler doing (or not doing) the "right"
> > optimization.
>
> I would not do a "naked" save here, please just use the construct
> I showed you with the %o7 register clobber.
Yes, I missed that save is not allocating any memory, which is
wrong. What I actually had in mind was this:
asm volatile ("save %sp, -96, %sp; flushw; restore");
My concern with the approach you are proposing is that compiler
may (in the future, perhaps) just optimize out the helper function,
making arrangements to save %o7 in one of the unused registers, thus
removing allocation of another register window and breaking it again.
Best regards,
--
Jurij Smakov jurij@wooyd.org
Key: http://www.wooyd.org/pgpkey/ KeyID: C99E03CC
next prev parent reply other threads:[~2011-10-22 9:43 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-07 23:22 longjmp question Jurij Smakov
2011-10-07 23:42 ` David Miller
2011-10-08 6:43 ` David Miller
2011-10-08 12:55 ` Jurij Smakov
2011-10-08 19:22 ` David Miller
2011-10-12 21:22 ` Jurij Smakov
2011-10-12 22:09 ` David Miller
2011-10-12 22:17 ` David Miller
2011-10-12 23:06 ` David Miller
2011-10-12 23:21 ` Jurij Smakov
2011-10-12 23:42 ` David Miller
2011-10-13 22:06 ` Jurij Smakov
2011-10-13 22:35 ` David Miller
2011-10-14 23:06 ` Jurij Smakov
2011-10-14 23:26 ` David Miller
2011-10-16 17:07 ` Jurij Smakov
2011-10-17 0:56 ` David Miller
2011-10-18 20:46 ` Jurij Smakov
2011-10-18 20:53 ` David Miller
2011-10-22 9:00 ` Jurij Smakov
2011-10-22 9:05 ` David Miller
2011-10-22 9:43 ` Jurij Smakov [this message]
2011-10-22 22:54 ` David Miller
2011-10-23 13:47 ` Jurij Smakov
2011-10-23 20:35 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111022094339.GA8547@wooyd.org \
--to=jurij@wooyd.org \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.