All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Henrik Rydberg" <rydberg@euromail.se>
To: "Gökçen Eraslan" <gokcen@pardus.org.tr>
Cc: Jiri Kosina <jkosina@suse.cz>, linux-input@vger.kernel.org
Subject: Re: [PATCH] HID: Add support for Macbook Pro 8 keyboards.
Date: Sat, 22 Oct 2011 14:04:26 +0200	[thread overview]
Message-ID: <20111022120426.GA2281@polaris.bitmath.org> (raw)
In-Reply-To: <1319220838-3297-1-git-send-email-gokcen@pardus.org.tr>

Hi Gökçen,

looks good, except

> diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
> index 7d27d2b..ffa7a85 100644
> --- a/drivers/hid/hid-ids.h
> +++ b/drivers/hid/hid-ids.h
> @@ -112,6 +112,9 @@
>  #define USB_DEVICE_ID_APPLE_ALU_REVB_ANSI	0x024f
>  #define USB_DEVICE_ID_APPLE_ALU_REVB_ISO	0x0250
>  #define USB_DEVICE_ID_APPLE_ALU_REVB_JIS	0x0251
> +#define USB_DEVICE_ID_APPLE_WELLSPRING5A_ANSI	0x0252
> +#define USB_DEVICE_ID_APPLE_WELLSPRING5A_ISO	0x0253
> +#define USB_DEVICE_ID_APPLE_WELLSPRING5A_JIS	0x0254
>  #define USB_DEVICE_ID_APPLE_ALU_WIRELESS_2009_ANSI  0x0239
>  #define USB_DEVICE_ID_APPLE_ALU_WIRELESS_2009_ISO   0x023a
>  #define USB_DEVICE_ID_APPLE_ALU_WIRELESS_2009_JIS   0x023b

which is not sorted.

Thanks,
Henrik
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2011-10-22 11:56 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-21 18:13 [PATCH] HID: Add support for Macbook Pro 8 keyboards Gökçen Eraslan
2011-10-22 12:04 ` Henrik Rydberg [this message]
2011-10-22 19:39   ` [PATCH] HID: Add support for Macbook Pro 8 keyboards and sort entries Gökçen Eraslan
2011-10-28  5:13     ` Gökçen Eraslan
2011-10-28 12:53       ` Henrik Rydberg
2011-10-28 13:01       ` Henrik Rydberg
2011-10-28 15:44         ` Jiri Kosina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111022120426.GA2281@polaris.bitmath.org \
    --to=rydberg@euromail.se \
    --cc=gokcen@pardus.org.tr \
    --cc=jkosina@suse.cz \
    --cc=linux-input@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.