From: Greg KH <greg@kroah.com>
To: Ravishankar Karkala Mallikarjunayya <ravishankar.km@greenturtles.in>
Cc: gregkh@suse.de, wfp5p@virginia.edu, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 02/24] Staging: comedi: fix printk coding style issue in
Date: Sun, 23 Oct 2011 10:19:03 +0200 [thread overview]
Message-ID: <20111023081903.GB13409@kroah.com> (raw)
In-Reply-To: <1319091550-2558-2-git-send-email-ravishankar.km@greenturtles.in>
On Thu, Oct 20, 2011 at 11:48:48AM +0530, Ravishankar Karkala Mallikarjunayya wrote:
> This is a patch to the serial2002.c file that fixes up a printk warning
> found by the checkpatch.pl tool.
> Converted printks to pr_<level>.
>
> Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankar.km@greenturtles.in>
> ---
> drivers/staging/comedi/drivers/serial2002.c | 9 +++++----
> 1 files changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/serial2002.c b/drivers/staging/comedi/drivers/serial2002.c
> index ade2202..6bd07ec 100644
> --- a/drivers/staging/comedi/drivers/serial2002.c
> +++ b/drivers/staging/comedi/drivers/serial2002.c
> @@ -431,7 +431,8 @@ static int serial_2002_open(struct comedi_device *dev)
> }
>
> tty_setspeed(devpriv->tty, devpriv->speed);
> - poll_channel(devpriv->tty, 31); /* Start reading configuration */
> + /* Start reading configuration */
> + poll_channel(devpriv->tty, 31);
> while (1) {
> struct serial_data data;
>
> @@ -824,7 +825,7 @@ static int serial2002_attach(struct comedi_device *dev,
> {
> struct comedi_subdevice *s;
>
> - printk("comedi%d: serial2002: ", dev->minor);
> + pr_debug("comedi%d: serial2002: attached\n", dev->minor);
You have a device, so use dev_dbg() instead of pr_debug()
> dev->board_name = thisboard->name;
> if (alloc_private(dev, sizeof(struct serial2002_private)) < 0)
> return -ENOMEM;
> @@ -832,7 +833,7 @@ static int serial2002_attach(struct comedi_device *dev,
> dev->close = serial_2002_close;
> devpriv->port = it->options[0];
> devpriv->speed = it->options[1];
> - printk("/dev/ttyS%d @ %d\n", devpriv->port, devpriv->speed);
> + pr_debug("/dev/ttyS%d @ %d\n", devpriv->port, devpriv->speed);
>
> if (alloc_subdevices(dev, 5) < 0)
> return -ENOMEM;
> @@ -891,7 +892,7 @@ static int serial2002_detach(struct comedi_device *dev)
> struct comedi_subdevice *s;
> int i;
>
> - printk("comedi%d: serial2002: remove\n", dev->minor);
> + pr_debug("comedi%d: serial2002: remove\n", dev->minor);
Same for the above two as well.
greg k-h
next prev parent reply other threads:[~2011-10-23 8:20 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-20 6:18 [PATCH 01/24] Staging: comedi: fix printk issue in das6402.c Ravishankar Karkala Mallikarjunayya
2011-10-20 6:18 ` [PATCH 02/24] Staging: comedi: fix printk coding style issue in Ravishankar Karkala Mallikarjunayya
2011-10-23 8:19 ` Greg KH [this message]
2011-10-20 6:18 ` [PATCH 03/24] Staging: comedi: fix warning issue in pcl818.c Ravishankar Karkala Mallikarjunayya
2011-10-23 8:20 ` Greg KH
2011-10-20 6:18 ` [PATCH 04/24] Staging: comedi: fix code cleanup issue in pcmuio.c Ravishankar Karkala Mallikarjunayya
2011-10-20 6:18 ` [PATCH 05/24] Staging: comedi: fix printk issue in c6xdigio.c Ravishankar Karkala Mallikarjunayya
2011-10-20 6:18 ` [PATCH 06/24] Staging: comedi: fix printk issue in ni_pcimio.c Ravishankar Karkala Mallikarjunayya
2011-10-20 6:18 ` [PATCH 7/24] Staging: comedi: fix printk issue in ni_labpc_cs.c Ravishankar Karkala Mallikarjunayya
2011-10-20 6:18 ` [PATCH 08/24] Staging: comedi: fix printk issue in das800.c Ravishankar Karkala Mallikarjunayya
2011-10-20 6:18 ` [PATCH 9/24] Staging: comedi: fix warning issue in dt3000.c Ravishankar Karkala Mallikarjunayya
2011-10-20 6:18 ` [PATCH 10/24] Staging: comedi: fix printk issue in cb_pcidas64.c Ravishankar Karkala Mallikarjunayya
2011-10-20 6:18 ` [PATCH 11/24] Staging: comedi: fix printk issue in cb_pcidda.c Ravishankar Karkala Mallikarjunayya
2011-10-20 6:18 ` [PATCH 12/24] Staging: comedi: fix printk issue in cb_pcidio.c Ravishankar Karkala Mallikarjunayya
2011-10-20 6:18 ` [PATCH 13/24] Staging: comedi: fix printk issue in cb_pcimdas.c Ravishankar Karkala Mallikarjunayya
2011-10-20 6:19 ` [PATCH 14/24] Staging: comedi: fix printk issue in cb_pcimdda.c Ravishankar Karkala Mallikarjunayya
2011-10-20 6:19 ` [PATCH 15/24] Staging: comedi: fix printk issue in contec_pci_dio.c Ravishankar Karkala Mallikarjunayya
2011-10-20 6:19 ` [PATCH 16/24] Staging: comedi: fix printk issue in amplc_pci230.c Ravishankar Karkala Mallikarjunayya
2011-10-20 6:19 ` [PATCH 17/24] Staging: comedi: fix printk issue in adv_pci_dio.c Ravishankar Karkala Mallikarjunayya
2011-10-20 6:19 ` [PATCH 18/24] Staging: comedi: fix printk issue in ni_at_a2150.c Ravishankar Karkala Mallikarjunayya
2011-10-20 6:19 ` [PATCH 19/24] Staging: comedi: fix warning issue in contec_pci_dio.c Ravishankar Karkala Mallikarjunayya
2011-10-20 6:19 ` [PATCH 20/24] Staging: comedi: fix printk issue in cb_pcidas.c Ravishankar Karkala Mallikarjunayya
2011-10-20 6:19 ` [PATCH 21/24] Staging: comedi: fix warning issue in cb_das16_cs.c Ravishankar Karkala Mallikarjunayya
2011-10-20 6:19 ` [PATCH 22/24] Staging: comedi: fix printk issue in das1800.c Ravishankar Karkala Mallikarjunayya
2011-10-20 6:19 ` [PATCH 23/24] Staging: comedi: fix printk issue in adv_pci1710.c Ravishankar Karkala Mallikarjunayya
2011-10-20 6:19 ` [PATCH 24/24] Staging: comedi: fix code cleanup in daqboard2000.c Ravishankar Karkala Mallikarjunayya
2011-10-23 8:18 ` [PATCH 01/24] Staging: comedi: fix printk issue in das6402.c Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111023081903.GB13409@kroah.com \
--to=greg@kroah.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=ravishankar.km@greenturtles.in \
--cc=wfp5p@virginia.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.