All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [Patch v2 6/7] powerpc/mpc8349emds: Migrate from spd_sdram to unified DDR driver
Date: Sun, 23 Oct 2011 11:53:23 +0200	[thread overview]
Message-ID: <20111023095323.2087511F9E79@gemini.denx.de> (raw)
In-Reply-To: <2A6300E8-A874-49AC-84CB-BE681AF1BF90@freescale.com>

Dear Kumar Gala,

In message <2A6300E8-A874-49AC-84CB-BE681AF1BF90@freescale.com> you wrote:
> 
> On Aug 26, 2011, at 1:32 PM, York Sun wrote:
> 
> > Update MPC8349EMDS to use unified DDR driver instead of spd_sdram.c.
> > The unified driver can initialize data using DDR controller. No need to
> > use DMA if just to initialze for ECC.
> > 
> > Signed-off-by: York Sun <yorksun@freescale.com>
> > Signed-off-by: Kim Phillips <kim.phillips@freescale.com>
> > ---
> > board/freescale/mpc8349emds/Makefile      |    1 +
> > board/freescale/mpc8349emds/ddr.c         |  107 +++++++++++++++++++++++++++++
> > board/freescale/mpc8349emds/mpc8349emds.c |   26 ++++---
> > include/configs/MPC8349EMDS.h             |   16 ++++
> > 4 files changed, 139 insertions(+), 11 deletions(-)
> > create mode 100644 board/freescale/mpc8349emds/ddr.c
> 
> applied to 85xx 'next'

Did you test it???


This patch breaks out-of-tree building of the MPC8349EMDS board:

+ MAKEALL_LOGDIR=/work/wd/tmp-ppc-LOG
+ BUILD_DIR=/work/wd/tmp-ppc
+ ./MAKEALL MPC8349EMDS
Configuring for MPC8349EMDS board...
make[1]: *** No rule to make target `/work/wd/tmp-ppc/arch/powerpc/cpu/mpc83xx/.depend.ddr-gen2', needed by `/work/wd/tmp-ppc/arch/powerpc/cpu/mpc83xx/.depend'.  Stop.
make[1]: *** No rule to make target `/work/wd/tmp-ppc/arch/powerpc/cpu/mpc83xx/.depend.ddr-gen2', needed by `/work/wd/tmp-ppc/arch/powerpc/cpu/mpc83xx/.depend'.  Stop.
make: *** [depend] Error 2

[Local building works.]


Note also that "make distclean" still leaves a file
arch/powerpc/cpu/mpc83xx/ddr-gen2.c

Please fix this, too.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Overflow on /dev/null, please empty the bit bucket.

  reply	other threads:[~2011-10-23  9:53 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-26 18:32 [U-Boot] [Patch v2 1/7] powerpc/mpc8xxx: Fix DDR code for empty first DIMM slot and enable DQS_en York Sun
2011-08-26 18:32 ` [U-Boot] [Patch v2 2/7] powerpc/mpc8xxx: Add SPD EEPROM address for single controller 2 slots York Sun
2011-09-16 14:41   ` Kumar Gala
2011-08-26 18:32 ` [U-Boot] [Patch v2 3/7] powerpc/mpc8xxx: Fix picos_to_mclk() and get_memory_clk_period_ps() York Sun
2011-09-16 14:42   ` Kumar Gala
2011-08-26 18:32 ` [U-Boot] [Patch v2 4/7] powerpc/mpc8xxx: Add DDR2 to unified DDR driver York Sun
2011-09-16 14:47   ` Kumar Gala
2011-08-26 18:32 ` [U-Boot] [Patch v2 5/7] powerpc/mpc83xx: Migrate from spd_sdram " York Sun
2011-09-16 14:57   ` Kumar Gala
2011-08-26 18:32 ` [U-Boot] [Patch v2 6/7] powerpc/mpc8349emds: " York Sun
2011-09-16 14:57   ` Kumar Gala
2011-10-23  9:53     ` Wolfgang Denk [this message]
2011-10-24 17:57       ` Kumar Gala
2011-12-07 20:40       ` Wolfgang Denk
2011-12-07 20:46         ` York Sun
2011-12-07 20:54           ` Wolfgang Denk
2011-12-07 21:36             ` [U-Boot] [GIT PULL] please pull u-boot-mpc83xx fixes Kim Phillips
2011-12-07 22:03               ` Wolfgang Denk
2011-08-26 18:32 ` [U-Boot] [Patch v2 7/7] powerpc/8xxx: Add support for interactive DDR programming interface York Sun
2011-09-16 15:17   ` Kumar Gala
2011-09-16 14:41 ` [U-Boot] [Patch v2 1/7] powerpc/mpc8xxx: Fix DDR code for empty first DIMM slot and enable DQS_en Kumar Gala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111023095323.2087511F9E79@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.