From: wangyanqing <udknight@gmail.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] init:enable usermodehelper as soon as we have a root filesystem
Date: Sun, 23 Oct 2011 22:43:33 +0800 [thread overview]
Message-ID: <20111023144333.GA2676@udknight.homenetwork> (raw)
before we have a root filesystem , it is useless to enable usermodehelper,
and it may cause bug if we enable usermodehelper too early.This patch
enable usermodehelper as soon as we have a root filesystem.
---
init/do_mounts.c | 3 +++
init/initramfs.c | 2 ++
init/main.c | 1 -
3 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/init/do_mounts.c b/init/do_mounts.c
index c0851a8..9575bdd 100644
--- a/init/do_mounts.c
+++ b/init/do_mounts.c
@@ -490,4 +490,7 @@ out:
devtmpfs_mount("dev");
sys_mount(".", "/", NULL, MS_MOVE, NULL);
sys_chroot((const char __user __force *)".");
+#ifndef CONFIG_BLK_DEV_INITRD
+ usermodehelper_enable();
+#endif
}
diff --git a/init/initramfs.c b/init/initramfs.c
index 2531811..881fc4b 100644
--- a/init/initramfs.c
+++ b/init/initramfs.c
@@ -581,6 +581,7 @@ static int __init populate_rootfs(void)
err = unpack_to_rootfs((char *)initrd_start,
initrd_end - initrd_start);
if (!err) {
+ usermodehelper_enable();
free_initrd();
return 0;
} else {
@@ -603,6 +604,7 @@ static int __init populate_rootfs(void)
initrd_end - initrd_start);
if (err)
printk(KERN_EMERG "Initramfs unpacking failed: %s\n", err);
+ usermodehelper_enable();
free_initrd();
#endif
}
diff --git a/init/main.c b/init/main.c
index 03b408d..2e232cb 100644
--- a/init/main.c
+++ b/init/main.c
@@ -730,7 +730,6 @@ static void __init do_basic_setup(void)
driver_init();
init_irq_proc();
do_ctors();
- usermodehelper_enable();
do_initcalls();
}
--
1.7.3.4
next reply other threads:[~2011-10-23 14:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-23 14:43 wangyanqing [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-10-23 15:09 [PATCH] init:enable usermodehelper as soon as we have a root filesystem wangyanqing
2011-10-27 0:39 ` wangyanqing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111023144333.GA2676@udknight.homenetwork \
--to=udknight@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.