From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RESEND PATCH v3] Add assert() for debug assertions
Date: Sun, 23 Oct 2011 19:11:26 +0200 [thread overview]
Message-ID: <20111023171126.B5F2A137213A@gemini.denx.de> (raw)
In-Reply-To: <CAJaTeTrUJH+p1jTU88d5KDv4EU57DiU+=_ibp9DZHXU78U1HdQ@mail.gmail.com>
Dear Mike Frysinger,
In message <CAJaTeTrUJH+p1jTU88d5KDv4EU57DiU+=_ibp9DZHXU78U1HdQ@mail.gmail.com> you wrote:
>
> >> +void __assert_fail(const char *assertion, const char *file, unsigned line,
> >> + const char *function)
> >> +{
> >> + /* This will not return */
> >> + panic("%s:%u: %s: Assertion `%s' failed.", file, line, function,
> >> + assertion);
> >> +}
> >
> > Can you please #ifdef it so it doesn't get added for the non-debug
> > case, too?
>
> most arches are building with --gc-sections now which means there is
> no overhead added for them. should we look at fixing the few holdouts
> rather than adding #ifdefs ?
I think Power does use --gc-sections, still I see code size growing.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
All your people must learn before you can reach for the stars.
-- Kirk, "The Gamesters of Triskelion", stardate 3259.2
prev parent reply other threads:[~2011-10-23 17:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-07 22:31 [U-Boot] [RESEND PATCH v3] Add assert() for debug assertions Simon Glass
2011-10-21 22:20 ` Wolfgang Denk
2011-10-22 2:59 ` Simon Glass
2011-10-23 8:35 ` Wolfgang Denk
2011-10-23 11:37 ` Mike Frysinger
2011-10-23 17:13 ` Wolfgang Denk
2011-10-23 5:35 ` Mike Frysinger
2011-10-23 17:11 ` Wolfgang Denk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111023171126.B5F2A137213A@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.