From: Greg KH <gregkh@suse.de>
To: Raghavendra K T <raghavendra.kt@linux.vnet.ibm.com>
Cc: Virtualization <virtualization@lists.linux-foundation.org>,
Gleb Natapov <gleb@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>,
x86@kernel.org, KVM <kvm@vger.kernel.org>,
Dave Jiang <dave.jiang@intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
LKML <linux-kernel@vger.kernel.org>,
Sedat Dilek <sedat.dilek@gmail.com>,
Yinghai Lu <yinghai@kernel.org>,
Marcelo Tosatti <mtosatti@redhat.com>,
Ingo Molnar <mingo@redhat.com>, Avi Kivity <avi@redhat.com>,
Rik van Riel <riel@redhat.com>,
Xen <xen-devel@lists.xensource.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Suzuki Poulose <suzuki@linux.vnet.ibm.com>,
Srivatsa Vaddagiri <vatsa@linux.vnet.ibm.com>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH RFC V2 1/5] debugfs: Add support to print u32 array in debugfs
Date: Mon, 24 Oct 2011 00:20:12 +0200 [thread overview]
Message-ID: <20111023222012.GB591@suse.de> (raw)
In-Reply-To: <20111023190403.16364.30897.sendpatchset@oc5400248562.ibm.com>
On Mon, Oct 24, 2011 at 12:34:04AM +0530, Raghavendra K T wrote:
> Add debugfs support to print u32-arrays in debugfs. Move the code from Xen to debugfs
> to make the code common for other users as well.
You forgot the kerneldoc for the function explaining what it is and how
to use it, and the EXPORT_SYMBOL_GPL() marking for the global function
as that's the only way it will be able to be used, right?
thanks,
greg k-h
next prev parent reply other threads:[~2011-10-23 22:23 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-23 19:03 [PATCH RFC V2 0/5] kvm : Paravirt-spinlock support for KVM guests Raghavendra K T
2011-10-23 19:03 ` Raghavendra K T
2011-10-23 19:04 ` [PATCH RFC V2 1/5] debugfs: Add support to print u32 array in debugfs Raghavendra K T
2011-10-23 22:20 ` Greg KH [this message]
2011-10-24 9:30 ` Raghavendra K T
2011-10-23 19:04 ` Raghavendra K T
2011-10-23 19:04 ` Raghavendra K T
2011-10-23 19:04 ` [PATCH RFC V2 2/5] debugfs: Renaming of xen functions and change unsigned to u32 Raghavendra K T
2011-10-23 19:04 ` Raghavendra K T
2011-10-23 22:19 ` Greg KH
2011-10-24 9:28 ` Raghavendra K T
2011-10-24 9:38 ` Greg KH
2011-10-23 19:04 ` Raghavendra K T
2011-10-23 19:05 ` [PATCH RFC V2 3/5] kvm hypervisor : Add two hypercalls to support pv-ticketlock Raghavendra K T
2011-10-23 19:05 ` Raghavendra K T
2011-10-24 10:01 ` Sasha Levin
2011-10-24 11:00 ` Raghavendra K T
2011-10-24 11:00 ` Raghavendra K T
2011-10-24 11:00 ` Raghavendra K T
2011-10-24 10:01 ` Sasha Levin
2011-10-24 10:14 ` Avi Kivity
2011-10-24 11:20 ` Raghavendra K T
2011-10-24 12:27 ` Srivatsa Vaddagiri
2011-10-24 13:09 ` Avi Kivity
2011-10-24 13:50 ` Srivatsa Vaddagiri
2011-10-25 18:24 ` Raghavendra K T
2011-10-26 10:34 ` Avi Kivity
2011-10-26 19:08 ` Raghavendra K T
2011-10-26 19:08 ` Raghavendra K T
2011-10-26 19:08 ` Raghavendra K T
2011-10-27 10:17 ` Avi Kivity
2011-10-27 10:17 ` Avi Kivity
2011-10-26 20:09 ` Jeremy Fitzhardinge
2011-10-26 20:09 ` Jeremy Fitzhardinge
2011-10-26 20:09 ` Jeremy Fitzhardinge
2011-10-23 19:05 ` Raghavendra K T
2011-10-23 19:07 ` [PATCH RFC V2 4/5] kvm guest : Added configuration support to enable debug information for KVM Guests Raghavendra K T
2011-10-23 19:07 ` Raghavendra K T
2011-10-23 19:07 ` Raghavendra K T
2011-10-24 10:01 ` Sasha Levin
2011-10-24 10:01 ` Sasha Levin
2011-10-24 18:45 ` Raghavendra K T
2011-10-24 18:45 ` Raghavendra K T
2011-10-24 18:45 ` Raghavendra K T
2011-10-24 10:15 ` Avi Kivity
2011-10-25 18:11 ` Raghavendra K T
2011-10-25 18:30 ` Jeremy Fitzhardinge
2011-10-23 19:07 ` [PATCH RFC V2 5/5] kvm guest : pv-ticketlocks support for linux guests running on KVM hypervisor Raghavendra K T
2011-10-23 19:07 ` Raghavendra K T
2011-10-24 10:01 ` Sasha Levin
2011-10-24 9:33 ` Raghavendra K T
2011-10-24 9:33 ` Raghavendra K T
2011-10-24 9:33 ` Raghavendra K T
2011-10-25 18:34 ` Jeremy Fitzhardinge
2011-10-26 19:23 ` Raghavendra K T
2011-10-26 19:46 ` Jeremy Fitzhardinge
2011-10-26 19:55 ` Raghavendra K T
2011-10-25 18:35 ` Jeremy Fitzhardinge
2011-10-26 19:25 ` Raghavendra K T
2011-10-23 19:07 ` Raghavendra K T
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111023222012.GB591@suse.de \
--to=gregkh@suse.de \
--cc=avi@redhat.com \
--cc=dave.jiang@intel.com \
--cc=gleb@redhat.com \
--cc=hpa@zytor.com \
--cc=jeremy.fitzhardinge@citrix.com \
--cc=konrad.wilk@oracle.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mtosatti@redhat.com \
--cc=peterz@infradead.org \
--cc=raghavendra.kt@linux.vnet.ibm.com \
--cc=riel@redhat.com \
--cc=sedat.dilek@gmail.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=suzuki@linux.vnet.ibm.com \
--cc=tglx@linutronix.de \
--cc=vatsa@linux.vnet.ibm.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xensource.com \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.