From: David Miller <davem@davemloft.net>
To: kth3321@gmail.com
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
romieu@fr.zoreil.com, suhwan@wiznet.co.kr, bongbong@wiznet.co.kr
Subject: Re: [PATCH net-next] w5300: add WIZnet W5300 Ethernet driver
Date: Mon, 24 Oct 2011 18:21:42 -0400 (EDT) [thread overview]
Message-ID: <20111024.182142.2299822581628382143.davem@davemloft.net> (raw)
In-Reply-To: <1319272916-5541-1-git-send-email-kth3321@gmail.com>
From: Taehun Kim <kth3321@gmail.com>
Date: Sat, 22 Oct 2011 17:41:56 +0900
> +struct wiz_private {
> + void __iomem *base;
> + struct net_device *dev;
> + u8 rxbuf_conf[MAX_SOCK_NUM];
> + u8 txbuf_conf[MAX_SOCK_NUM];
> + struct net_device_stats stats;
> + struct napi_struct napi;
> + spinlock_t lock;
> + u32 msg_enable;
> +};
You don't need to have a private net_device_stats, just use the
one in struct net_device, and then you can also get rid of your
private ->ndo_get_stats() method.
next prev parent reply other threads:[~2011-10-24 22:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-22 8:41 [PATCH net-next] w5300: add WIZnet W5300 Ethernet driver Taehun Kim
2011-10-24 22:21 ` David Miller [this message]
2011-10-29 18:29 ` Taehun Kim
-- strict thread matches above, loose matches on Subject: below --
2011-11-07 14:37 [PATCH net-next] W5300: Add " Taehun Kim
2011-11-08 19:09 ` Ben Hutchings
2011-11-08 20:06 ` Ben Hutchings
2011-11-18 16:15 ` Taehun Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111024.182142.2299822581628382143.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bongbong@wiznet.co.kr \
--cc=kth3321@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
--cc=suhwan@wiznet.co.kr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.