From: Thomas Rast <trast@student.ethz.ch>
To: Franz Schrober <franzschrober@yahoo.de>
Cc: "git@vger.kernel.org" <git@vger.kernel.org>,
"marat@slonopotamus.org" <marat@slonopotamus.org>,
"rctay89@gmail.com" <rctay89@gmail.com>,
"gitster@pobox.com" <gitster@pobox.com>
Subject: Re: Possible diff regression in v1.7.6-473-g27af01d
Date: Mon, 24 Oct 2011 11:38:51 +0200 [thread overview]
Message-ID: <201110241138.51448.trast@student.ethz.ch> (raw)
In-Reply-To: <1319448227.70497.YahooMailNeo@web29402.mail.ird.yahoo.com>
Franz Schrober wrote:
> Hi,
>
> I am using git to manage some patches on top of the actual upstream files, but noticed that the result of git-format-patch changed between 4bfe7cb6668c43c1136304bbb17eea1b3ddf0237 and 27af01d552331eacf1ed2671b2b4b6ad4c268106
>
> I've attached two input files (I tried to provide a minimal example... I am not sure if a smaller example is possible but at least both files are smaller than 10 lines) and the results with version 1.7.6.3 and and 1.7.7. The diffs were created using: git diff anonymized_orig anonymized_new
>
> My .gitconfig file is empty.
I'm not sure why you call this a regression. For the benefit of
people who hate saving attachments, you used
$ paste anonymized_orig anonymized_new | xclip
0 1
0 2
0 0
0 3
4
5
6
7
the old diff was
--- a/anonymized_orig
+++ b/anonymized_new
@@ -1,4 +1,8 @@
-0
-0
-0
-0
+1
+2
+0
+3
+4
+5
+6
+7
and the new diff is
--- a/anonymized_orig
+++ b/anonymized_new
@@ -1,4 +1,8 @@
+1
+2
0
-0
-0
-0
+3
+4
+5
+6
+7
So the new diff correctly represents the change, and on top of that is
shorter (by only one line, admittedly). What makes it a regression?
--
Thomas Rast
trast@{inf,student}.ethz.ch
next prev parent reply other threads:[~2011-10-24 9:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-24 9:23 Possible diff regression in v1.7.6-473-g27af01d Franz Schrober
2011-10-24 9:38 ` Thomas Rast [this message]
2011-10-24 10:11 ` Tay Ray Chuan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201110241138.51448.trast@student.ethz.ch \
--to=trast@student.ethz.ch \
--cc=franzschrober@yahoo.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=marat@slonopotamus.org \
--cc=rctay89@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.