From: "Serge E. Hallyn" <serge.hallyn@canonical.com>
To: "Andrew G. Morgan" <morgan@kernel.org>
Cc: "Serge E. Hallyn" <serge@hallyn.com>,
David Howells <dhowells@redhat.com>,
linux-kernel@vger.kernel.org, ebiederm@xmission.com,
akpm@linux-foundation.org, oleg@redhat.com, richard@nod.at,
mikevs@xs4all.net, segoon@openwall.com, gregkh@suse.de,
eparis@redhat.com
Subject: Re: [PATCH 05/10] user namespace: clamp down users of cap_raised
Date: Mon, 24 Oct 2011 12:28:42 -0500 [thread overview]
Message-ID: <20111024172842.GA13556@sergelap> (raw)
In-Reply-To: <CALQRfL4zCbzr_Fa0ySi96j06nw7ifocCxUjYUs6vXxeNvjCutQ@mail.gmail.com>
Quoting Andrew G. Morgan (morgan@kernel.org):
> Serge,
>
> It seems as if this whole thing is really idiomatic. How about?
>
> #define IN_ROOT_USER_NS_CAPABLE(cap) \
> ((current_user_ns() == &init_user_ns) && cap_raised(current_cap(), cap))
My objection to this was that it seems to encourage others to use it :) I'm
not sure we want that. Also, IN_ROOT_USER_NS seems more generally useful.
But if I'm the only one who feels this way I'll go ahead and do it...
thanks,
-serge
next prev parent reply other threads:[~2011-10-24 17:28 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-18 21:54 user namespaces: fix some uid/privilege leaks Serge Hallyn
2011-10-18 21:54 ` [PATCH 1/9] pid_ns: ensure pid is not freed during kill_pid_info_as_uid Serge Hallyn
2011-10-18 21:54 ` [PATCH 2/9] user namespace: usb: make usb urbs user namespace aware (v2) Serge Hallyn
2011-10-18 21:54 ` [PATCH 3/9] user namespace: make signal.c respect user namespaces (v4) Serge Hallyn
2011-10-18 21:54 ` [PATCH 4/9] User namespace: don't allow sysctl in non-init user ns (v2) Serge Hallyn
2011-10-18 21:54 ` [PATCH 5/9] user namespace: clamp down users of cap_raised Serge Hallyn
2011-10-19 4:33 ` Andrew G. Morgan
2011-10-19 9:01 ` David Howells
2011-10-20 13:16 ` Serge E. Hallyn
2011-10-24 14:43 ` [PATCH 05/10] " Serge E. Hallyn
2011-10-24 15:47 ` Andrew G. Morgan
2011-10-24 17:28 ` Serge E. Hallyn [this message]
2011-10-25 0:43 ` Andrew G. Morgan
2011-10-25 3:03 ` Serge E. Hallyn
2011-10-25 17:33 ` Eric Paris
2011-10-25 20:09 ` Serge E. Hallyn
2011-10-20 13:01 ` [PATCH 5/9] " Serge E. Hallyn
2011-10-18 21:54 ` [PATCH 6/9] Add Documentation/namespaces/user_namespace.txt (v3) Serge Hallyn
2011-10-19 9:36 ` David Howells
2011-10-20 12:58 ` Serge E. Hallyn
2011-10-26 20:33 ` [PATCH 06/10] Add Documentation/namespaces/user_namespace.txt (v4) Serge E. Hallyn
2011-10-18 21:54 ` [PATCH 7/9] user namespace: make each net (net_ns) belong to a user_ns Serge Hallyn
2011-10-18 21:54 ` [PATCH 8/9] protect cap_netlink_recv from user namespaces Serge Hallyn
2011-10-18 21:54 ` [PATCH 9/9] make net/core/scm.c uid comparisons user namespace aware Serge Hallyn
2011-10-18 22:14 ` Joe Perches
2011-10-18 23:22 ` Serge E. Hallyn
2011-10-19 2:25 ` [PATCH 9/9] make net/core/scm.c uid comparisons user namespace aware (v2) Serge E. Hallyn
2011-10-19 13:52 ` [PATCH 9/9] make net/core/scm.c uid comparisons user namespace aware Eric W. Biederman
2011-10-20 12:58 ` Serge E. Hallyn
2011-10-20 13:35 ` Eric W. Biederman
2011-10-20 14:14 ` Serge E. Hallyn
2011-10-24 4:15 ` Serge E. Hallyn
2011-10-24 4:27 ` Eric W. Biederman
2011-10-20 14:24 ` Serge E. Hallyn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111024172842.GA13556@sergelap \
--to=serge.hallyn@canonical.com \
--cc=akpm@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=ebiederm@xmission.com \
--cc=eparis@redhat.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mikevs@xs4all.net \
--cc=morgan@kernel.org \
--cc=oleg@redhat.com \
--cc=richard@nod.at \
--cc=segoon@openwall.com \
--cc=serge@hallyn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.