From mboxrd@z Thu Jan  1 00:00:00 1970
From: Wolfgang Denk <wd@denx.de>
Date: Mon, 24 Oct 2011 20:48:35 +0200
Subject: [U-Boot] [PATCH 2/2] bootstage: Make use of BOOTSTAGE_ID_RUN_OS
	in show_boot_progress()
In-Reply-To: <CAPnjgZ3q-E9vDwZD1bri36emTWoDFUDDk5is_qoLcw=v3KDdzw@mail.gmail.com>
References: <1318790446-24792-1-git-send-email-sjg@chromium.org>
	<1318790446-24792-3-git-send-email-sjg@chromium.org>
	<20111023184400.C92671222226@gemini.denx.de>
	<CAPnjgZ3q-E9vDwZD1bri36emTWoDFUDDk5is_qoLcw=v3KDdzw@mail.gmail.com>
Message-ID: <20111024184835.88E101408E9B@gemini.denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Simon Glass,

In message <CAPnjgZ3q-E9vDwZD1bri36emTWoDFUDDk5is_qoLcw=v3KDdzw@mail.gmail.com> you wrote:
> 
> IMHO we would be better off with a function call like
>
>  ? ? ? ?show_boot_error(BOOTSTAGE_ID_RUN_OS);
>
> even if this is a macro. It is more explicit about the fact that we
> are reporting an error. Does that sound ok?

That's fine with me. [Just make sure we don't increase the code size.]

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
In the bathtub of history the truth is harder to hold than the  soap,
and much more difficult to find ...     - Terry Pratchett, _Sourcery_