Re: [patch net-next V4] net: introduce ethernet teaming device

[Jiri Pirko <jpirko@redhat.com>]

Mon, Oct 24, 2011 at 07:22:36PM CEST, mirqus@gmail.com wrote:
>2011/10/24 Jiri Pirko <jpirko@redhat.com>:
>> This patch introduces new network device called team. It supposes to be
>> very fast, simple, userspace-driven alternative to existing bonding
>> driver.
>[...]
>>  drivers/net/team/team.c                   | 1573 +++++++++++++++++++++++++++++
>>  drivers/net/team/team_mode_activebackup.c |  152 +++
>>  drivers/net/team/team_mode_roundrobin.c   |  107 ++
>
>I think this mode-modularity is overkill. One mode will compile to at
>most a few hundred bytes of code+data, but will use at least 10 times
>that to get loaded and tracked properly. How often/how many more modes
>you anticipate to be introduced? You could just keep the modular
>design but drop the kernel module separation and maybe have modes
>conditionally compiled (for those from the embedded world squeezing
>every byte).

~3-4 modes are coming in at least. I presume it would be possible to
squeeze "bacic modes" like roundrobin and activebackup directly into
team.c (or into team_basic_modes.c compiled in team.ko). But I would
leave that to future follow up patch.

>
>Best Regards,
>Michał Mirosław