From: Ted Ts'o <tytso@mit.edu>
To: Dmitry Monakhov <dmonakhov@openvz.org>
Cc: linux-ext4@vger.kernel.org, achender@linux.vnet.ibm.com
Subject: Re: [PATCH 3/6] ext4: Do not clear EOFBLOCKS_FL too soon
Date: Tue, 25 Oct 2011 04:18:34 -0400 [thread overview]
Message-ID: <20111025081834.GB31921@thunk.org> (raw)
In-Reply-To: <1319144939-28801-4-git-send-email-dmonakhov@openvz.org>
On Fri, Oct 21, 2011 at 01:08:56AM +0400, Dmitry Monakhov wrote:
> ext4_ext_insert_extent() may fail due to number of reasons (ENOSPC)
> so let's update eof flag only after extent was successfully inserted.
>
> Signed-off-by: Dmitry Monakhov <dmonakhov@openvz.org>
The problem with this patch is that if the check_eofblocks_fl() fails,
the patch jumps to out: and doesn't undo the block allocation and
extent tree manipulation.
I suspect a better way of solving this problem is to keep the existing
order, but to save the state of eofblocks flag, and if
ext4_ext_insert_extent() fails, to restore the state of the eofblocks
flag before jumping to the exit routine.
- Ted
next prev parent reply other threads:[~2011-10-25 8:18 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-20 21:08 [PATCH 0/6] ext4: cleanups and regression fixes for grow/shrink logic V2 Dmitry Monakhov
2011-10-20 21:08 ` [PATCH 1/6] ext4: cleanup ext4_ext_grow_indepth code Dmitry Monakhov
2011-10-22 5:27 ` Ted Ts'o
2011-10-20 21:08 ` [PATCH 2/6] ext4: move inode indepth shrink logic to didicated function Dmitry Monakhov
2011-10-25 8:01 ` Ted Ts'o
2011-10-28 10:47 ` Dmitry Monakhov
2011-10-20 21:08 ` [PATCH 3/6] ext4: Do not clear EOFBLOCKS_FL too soon Dmitry Monakhov
2011-10-25 8:18 ` Ted Ts'o [this message]
2011-10-25 11:57 ` Dmitry Monakhov
2011-10-20 21:08 ` [PATCH 4/6] ext4: remove messy logic from ext4_ext_rm_leaf Dmitry Monakhov
2011-10-25 11:44 ` Ted Ts'o
2011-10-20 21:08 ` [PATCH 5/6] ext4: fix punch_hole extend handler Dmitry Monakhov
2011-10-25 12:05 ` Ted Ts'o
2011-10-25 12:35 ` Dmitry Monakhov
2011-10-26 13:38 ` Ted Ts'o
2011-10-20 21:08 ` [PATCH 6/6] ext4: update EOFBLOCKS flag on fallocate properly Dmitry Monakhov
2011-10-25 12:22 ` Ted Ts'o
2011-10-28 21:40 ` Andreas Dilger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111025081834.GB31921@thunk.org \
--to=tytso@mit.edu \
--cc=achender@linux.vnet.ibm.com \
--cc=dmonakhov@openvz.org \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.