All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stanislav Kinsbursky <skinsbursky@parallels.com>
To: Trond.Myklebust@netapp.com
Cc: linux-nfs@vger.kernel.org, xemul@parallels.com, neilb@suse.de,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	bfields@fieldses.org, davem@davemloft.net, devel@openvz.org
Subject: [PATCH v6 2/8] SUNRPC: use rpcbind reference counting helpers
Date: Tue, 25 Oct 2011 14:16:48 +0300	[thread overview]
Message-ID: <20111025101644.12689.45595.stgit@localhost6.localdomain6> (raw)
In-Reply-To: <20111025100826.12689.46944.stgit@localhost6.localdomain6>

All is simple: we just increase users counter if rpcbind clients has been
created already. Otherwise we create them and set users counter to 1.

Signed-off-by: Stanislav Kinsbursky <skinsbursky@parallels.com>

---
 net/sunrpc/rpcb_clnt.c |   12 ++++--------
 1 files changed, 4 insertions(+), 8 deletions(-)

diff --git a/net/sunrpc/rpcb_clnt.c b/net/sunrpc/rpcb_clnt.c
index 9fcdb42..7e5a0f8 100644
--- a/net/sunrpc/rpcb_clnt.c
+++ b/net/sunrpc/rpcb_clnt.c
@@ -259,9 +259,7 @@ static int rpcb_create_local_unix(void)
 		clnt4 = NULL;
 	}
 
-	/* Protected by rpcb_create_local_mutex */
-	rpcb_local_clnt = clnt;
-	rpcb_local_clnt4 = clnt4;
+	rpcb_set_local(clnt, clnt4);
 
 out:
 	return result;
@@ -313,9 +311,7 @@ static int rpcb_create_local_net(void)
 		clnt4 = NULL;
 	}
 
-	/* Protected by rpcb_create_local_mutex */
-	rpcb_local_clnt = clnt;
-	rpcb_local_clnt4 = clnt4;
+	rpcb_set_local(clnt, clnt4);
 
 out:
 	return result;
@@ -330,11 +326,11 @@ static int rpcb_create_local(void)
 	static DEFINE_MUTEX(rpcb_create_local_mutex);
 	int result = 0;
 
-	if (rpcb_local_clnt)
+	if (rpcb_get_local())
 		return result;
 
 	mutex_lock(&rpcb_create_local_mutex);
-	if (rpcb_local_clnt)
+	if (rpcb_get_local())
 		goto out;
 
 	if (rpcb_create_local_unix() != 0)


  parent reply	other threads:[~2011-10-25 10:16 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-25 11:15 [PATCH v6 0/8] SUNRPC: make rpcbind clients allocated and destroyed dynamically Stanislav Kinsbursky
2011-10-25 11:16 ` [PATCH v6 1/8] SUNRPC: introduce helpers for reference counted rpcbind clients Stanislav Kinsbursky
2011-10-25 11:16   ` Trond Myklebust
2011-10-25 11:16     ` Trond Myklebust
2011-10-25 12:41     ` Stanislav Kinsbursky
2011-10-25 12:45       ` Trond Myklebust
2011-10-25 12:45         ` Trond Myklebust
2011-10-25 13:25         ` Stanislav Kinsbursky
2011-10-25 11:16 ` Stanislav Kinsbursky [this message]
2011-10-25 11:16 ` [PATCH v6 3/8] SUNRPC: introduce svc helpers for prepairing rpcbind infrastructure Stanislav Kinsbursky
2011-10-25 11:17 ` [PATCH v6 4/8] SUNRPC: setup rpcbind clients if service requires it Stanislav Kinsbursky
2011-10-27 21:27   ` J. Bruce Fields
2011-10-27 21:27     ` J. Bruce Fields
2011-10-28  9:27     ` Stanislav Kinsbursky
2011-10-25 11:17 ` [PATCH v6 5/8] SUNRPC: cleanup service destruction Stanislav Kinsbursky
2011-10-27 21:30   ` J. Bruce Fields
2011-10-28  9:49     ` Stanislav Kinsbursky
2011-10-25 11:17 ` [PATCH v6 6/8] NFSd: call svc rpcbind cleanup explicitly Stanislav Kinsbursky
2011-10-25 11:17 ` [PATCH v6 7/8] SUNRPC: remove rpcbind clients creation during service registering Stanislav Kinsbursky
2011-10-25 11:17 ` [PATCH v6 8/8] SUNRPC: remove rpcbind clients destruction on module cleanup Stanislav Kinsbursky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111025101644.12689.45595.stgit@localhost6.localdomain6 \
    --to=skinsbursky@parallels.com \
    --cc=Trond.Myklebust@netapp.com \
    --cc=bfields@fieldses.org \
    --cc=davem@davemloft.net \
    --cc=devel@openvz.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=neilb@suse.de \
    --cc=netdev@vger.kernel.org \
    --cc=xemul@parallels.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.