From: Flavio Leitner <fbl@redhat.com>
To: "Maciej Żenczykowski" <zenczykowski@gmail.com>
Cc: "Maciej Żenczykowski" <maze@google.com>, netdev@vger.kernel.org
Subject: Re: [PATCH] net: make bonding slaves honour master's skb->priority
Date: Tue, 25 Oct 2011 11:08:08 -0200 [thread overview]
Message-ID: <20111025110808.27db8487@asterix.rh> (raw)
In-Reply-To: <1319519056-21677-1-git-send-email-zenczykowski@gmail.com>
On Mon, 24 Oct 2011 22:04:16 -0700
Maciej Żenczykowski <zenczykowski@gmail.com> wrote:
> From: Maciej Żenczykowski <maze@google.com>
>
> Signed-off-by: Maciej Żenczykowski <maze@google.com>
> ---
> drivers/net/bonding/bond_main.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/bonding/bond_main.c
> b/drivers/net/bonding/bond_main.c index 41430ba..2cbc2f8 100644
> --- a/drivers/net/bonding/bond_main.c
> +++ b/drivers/net/bonding/bond_main.c
> @@ -395,7 +395,6 @@ int bond_dev_queue_xmit(struct bonding *bond,
> struct sk_buff *skb, struct net_device *slave_dev)
> {
> skb->dev = slave_dev;
> - skb->priority = 1;
>
> skb->queue_mapping = bond_queue_mapping(skb);
>
I tripped on it few times and never understood why we
were fixing the priority at this point.
thanks,
Acked-by: Flavio Leitner <fbl@redhat.com>
next prev parent reply other threads:[~2011-10-25 13:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-25 4:41 [PATCH] net: make bonding slaves honour master's skb->priority Maciej Żenczykowski
2011-10-25 4:58 ` Jay Vosburgh
2011-10-25 4:58 ` David Miller
2011-10-25 5:02 ` Maciej Żenczykowski
2011-10-25 5:04 ` Maciej Żenczykowski
2011-10-25 13:08 ` Flavio Leitner [this message]
2011-10-25 16:25 ` Maciej Żenczykowski
2011-10-25 16:45 ` Jay Vosburgh
2011-10-25 23:22 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111025110808.27db8487@asterix.rh \
--to=fbl@redhat.com \
--cc=maze@google.com \
--cc=netdev@vger.kernel.org \
--cc=zenczykowski@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.