From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756630Ab1JYOwL (ORCPT ); Tue, 25 Oct 2011 10:52:11 -0400 Received: from e2.ny.us.ibm.com ([32.97.182.142]:46733 "EHLO e2.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756550Ab1JYOwJ (ORCPT ); Tue, 25 Oct 2011 10:52:09 -0400 Date: Tue, 25 Oct 2011 19:48:12 +0530 From: Srikar Dronamraju To: Peter Zijlstra , "H. Peter Anvin" Cc: Steven Rostedt , Linus Torvalds , Christoph Hellwig , Ananth N Mavinakayanahalli , Thomas Gleixner , Andi Kleen , Oleg Nesterov , Andrew Morton , Jim Keniston , Roland McGrath , Shuah Khan , Ingo Molnar , Alexander van Heukelum , Russell King , LKML Subject: [RESEND] [RFC][PATCH X86_32 1/2]: Call do_notify_resume() with interrupts enabled Message-ID: <20111025141812.GA21225@linux.vnet.ibm.com> Reply-To: Srikar Dronamraju MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline User-Agent: Mutt/1.5.20 (2009-06-14) x-cbid: 11102514-5112-0000-0000-000001440457 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org do_notify_resume() gets called with interrupts disabled on x86_32. This is different from the x86_64 behavior, where interrupts are enabled at the time. Queries on lkml on this issue hasn't yielded any clear answer. Lets make x86_32 behave the same as x86_64, unless there is a real reason to maintain status quo. Please refer https://lkml.org/lkml/2011/9/27/130 for more details A similar change was suggested in arm https://lkml.org/lkml/2011/8/25/231 My 32-bit machine works fine (tm) with the patch below Signed-off-by: Srikar Dronamraju --- arch/x86/kernel/entry_32.S | 4 ++++ 1 files changed, 4 insertions(+) diff --git a/arch/x86/kernel/entry_32.S b/arch/x86/kernel/entry_32.S index f3f6f53..22d0e21 100644 --- a/arch/x86/kernel/entry_32.S +++ b/arch/x86/kernel/entry_32.S @@ -625,6 +625,8 @@ work_notifysig: # deal with pending signals and movl %esp, %eax jne work_notifysig_v86 # returning to kernel-space or # vm86-space + TRACE_IRQS_ON + ENABLE_INTERRUPTS(CLBR_NONE) xorl %edx, %edx call do_notify_resume jmp resume_userspace_sig @@ -638,6 +640,8 @@ work_notifysig: # deal with pending signals and #else movl %esp, %eax #endif + TRACE_IRQS_ON + ENABLE_INTERRUPTS(CLBR_NONE) xorl %edx, %edx call do_notify_resume jmp resume_userspace_sig