From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olaf Hering Subject: Re: [PATCH 10 of 15] xenpaging: compare both token and path when checking for @releaseDomain event Date: Tue, 25 Oct 2011 20:02:39 +0200 Message-ID: <20111025180239.GA14805@aepfle.de> References: <0b7d7a2bd6673f358faf.1319189504@probook.site> <20134.62630.115259.632324@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Content-Disposition: inline In-Reply-To: <20134.62630.115259.632324@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Ian Jackson Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On Tue, Oct 25, Ian Jackson wrote: > Olaf Hering writes ("[Xen-devel] [PATCH 10 of 15] xenpaging: compare both token and path when checking for @releaseDomain event"): > > xenpaging: compare both token and path when checking for @releaseDomain event > > > > Subsequent patches will use xenstored to store the numbers of pages > > xenpaging is suppose to page-out. A domain_id value could be > > misinterpreted as number of pages. Compare both path and token to > > recognize the @releaseDomain event. > > I'm not sure I understand. What are you currently using as the > token ? The token as well as the path should be sufficient to be able > to tell what the event is, so this patch makes me suspicious ... I was under the impression there could be identical tokens for different paths, and that the actual value of the watched path is part of XS_WATCH_TOKEN. So this patch tries to make the detection of the @releaseDomain event more robust. But since the token seems to be unique (docs/misc/xenstore.txt has no further description of 'token'), only the DPRINTF part of my patch should be kept. Please drop this change, I will add the DPRINTF in a separate patch. Olaf