From: Marek Vasut <marek.vasut@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] debugX macro
Date: Wed, 26 Oct 2011 00:16:29 +0200 [thread overview]
Message-ID: <201110260016.30086.marek.vasut@gmail.com> (raw)
In-Reply-To: <CANr=Z=aHrunoWkjCFj1ORsNXSfTegV=S=ACRv24bLn82KBUfog@mail.gmail.com>
> On Sun, Oct 23, 2011 at 12:23 PM, Wolfgang Denk <wd@denx.de> wrote:
> > Dear Marek Vasut,
> >
> > In message <201110231646.59439.marek.vasut@gmail.com> you wrote:
> >> I've been doing the debug() cleanup and found the debugX() macro is used
> >> only in very few patches. Maybe punting it altogether won't hurt.
> >>
> >> The following do use it:
> >> ./board/spc1920/hpi.c
> >> ./drivers/mtd/nand/s3c2410_nand.c
> >>
> >> Opinions?
> >
> > Dump it!
>
> I'm working on a patch to rework the net subsystem and I find it quite
> useful for filtering debug traces to a manageable level. I think it
> should stay around.
>
> Thanks
> -Joe
Hi Joe,
why can't you just reimplement it properly with your patchset ? Currently, all
the uses of this macro in the tree are bogus so your code might be a good
example.
Cheers
prev parent reply other threads:[~2011-10-25 22:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-23 14:46 [U-Boot] debugX macro Marek Vasut
2011-10-23 17:23 ` Wolfgang Denk
2011-10-23 20:46 ` Marek Vasut
2011-10-25 17:11 ` Joe Hershberger
2011-10-25 22:16 ` Marek Vasut [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201110260016.30086.marek.vasut@gmail.com \
--to=marek.vasut@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.