From: Jakub Narebski <jnareb@gmail.com>
To: Drew Northup <drew.northup@maine.edu>
Cc: Ramsay Jones <ramsay@ramsay1.demon.co.uk>,
Junio C Hamano <gitster@pobox.com>,
GIT Mailing-list <git@vger.kernel.org>
Subject: Re: [PATCH] gitweb/Makefile: Remove static/gitweb.js in the clean target
Date: Wed, 26 Oct 2011 02:36:58 +0200 [thread overview]
Message-ID: <201110260236.59509.jnareb@gmail.com> (raw)
In-Reply-To: <1319583484.10399.41.camel@drew-northup.unet.maine.edu>
Drew Northup napisał:
> On Tue, 2011-10-25 at 18:15 +0100, Ramsay Jones wrote:
> > Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
> > ---
> > gitweb/Makefile | 4 +++-
> > 1 files changed, 3 insertions(+), 1 deletions(-)
> >
> > diff --git a/gitweb/Makefile b/gitweb/Makefile
> > index 1c85b5f..4191c6b 100644
> > --- a/gitweb/Makefile
> > +++ b/gitweb/Makefile
> > @@ -185,7 +185,9 @@ install: all
> > ### Cleaning rules
> >
> > clean:
> > - $(RM) gitweb.cgi static/gitweb.min.js static/gitweb.min.css GITWEB-BUILD-OPTIONS
> > + $(RM) gitweb.cgi static/gitweb.js \
> > + static/gitweb.min.js static/gitweb.min.css \
> > + GITWEB-BUILD-OPTIONS
> >
> > .PHONY: all clean install test test-installed .FORCE-GIT-VERSION-FILE FORCE
> >
>
> Forgive me for sounding a bit numb, but what does this fix? I don't see
> it in the commit message.
gitweb.js is nowadays a generated file. Though that bit should be
in commit message...
--
Jakub Narebski
Poland
next prev parent reply other threads:[~2011-10-26 0:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-25 17:15 [PATCH] gitweb/Makefile: Remove static/gitweb.js in the clean target Ramsay Jones
2011-10-25 22:58 ` Drew Northup
2011-10-26 0:36 ` Jakub Narebski [this message]
2011-10-26 21:30 ` Ramsay Jones
2011-10-27 17:49 ` Junio C Hamano
2011-10-29 19:59 ` Ramsay Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201110260236.59509.jnareb@gmail.com \
--to=jnareb@gmail.com \
--cc=drew.northup@maine.edu \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=ramsay@ramsay1.demon.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.