From: Ted Ts'o <tytso@mit.edu>
To: Eric Sandeen <sandeen@redhat.com>
Cc: ext4 development <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH] ext4: use ext4_reserve_inode_write in ext4_xattr_set_handle
Date: Wed, 26 Oct 2011 03:40:36 -0400 [thread overview]
Message-ID: <20111026074036.GN31921@thunk.org> (raw)
In-Reply-To: <4EA6F749.3000308@redhat.com>
On Tue, Oct 25, 2011 at 12:52:09PM -0500, Eric Sandeen wrote:
> ext4_mark_iloc_dirty() says:
>
> * The caller must have previously called ext4_reserve_inode_write().
> * Give this, we know that the caller already has write access to iloc->bh.
>
> ext4_xattr_set_handle, however, just open-codes it. May as well use
> the helper function for consistency.
>
> No bug here, just tidiness.
>
> (Note: on cleanup path, ext4_reserve_inode_write sets
> the bh to NULL if it returns an error, and brelse() of
> a null bh is handled gracefully).
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Applied, thanks.
- Ted
prev parent reply other threads:[~2011-10-26 7:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-25 17:52 [PATCH] ext4: use ext4_reserve_inode_write in ext4_xattr_set_handle Eric Sandeen
2011-10-26 7:40 ` Ted Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111026074036.GN31921@thunk.org \
--to=tytso@mit.edu \
--cc=linux-ext4@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.