From mboxrd@z Thu Jan 1 00:00:00 1970 From: gregkh@suse.de (Greg KH) Date: Wed, 26 Oct 2011 14:17:06 +0200 Subject: [PATCH] lib: devres: add convenience function to remap a resource In-Reply-To: <20111025153538.GA13012@google.com> References: <1319548607-28427-1-git-send-email-w.sang@pengutronix.de> <20111025153538.GA13012@google.com> Message-ID: <20111026121706.GC23457@suse.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Oct 25, 2011 at 08:35:38AM -0700, Tejun Heo wrote: > On Tue, Oct 25, 2011 at 03:16:47PM +0200, Wolfram Sang wrote: > > Almost every platform_driver does the three steps get_resource, > > request_mem_region, ioremap. This does not only lead to a lot of code > > duplication, but also a huge number of similar error strings and > > inconsistent error codes on failure. So, introduce a helper function > > which simplifies remapping a resource and make it hard to do something > > wrong and add documentation for it. > > > > Signed-off-by: Wolfram Sang > > Cc: Grant Likely > > Cc: Tejun Heo > > Cc: Greg KH > > Acked-by: Tejun Heo > > Greg, can you please take this one? Ok, I'll queue it up after the 3.2 merge window is over, for the 3.3 release. thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932870Ab1JZMU4 (ORCPT ); Wed, 26 Oct 2011 08:20:56 -0400 Received: from cantor2.suse.de ([195.135.220.15]:33374 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932751Ab1JZMUz (ORCPT ); Wed, 26 Oct 2011 08:20:55 -0400 Date: Wed, 26 Oct 2011 14:17:06 +0200 From: Greg KH To: Tejun Heo Cc: Wolfram Sang , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Grant Likely Subject: Re: [PATCH] lib: devres: add convenience function to remap a resource Message-ID: <20111026121706.GC23457@suse.de> References: <1319548607-28427-1-git-send-email-w.sang@pengutronix.de> <20111025153538.GA13012@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20111025153538.GA13012@google.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 25, 2011 at 08:35:38AM -0700, Tejun Heo wrote: > On Tue, Oct 25, 2011 at 03:16:47PM +0200, Wolfram Sang wrote: > > Almost every platform_driver does the three steps get_resource, > > request_mem_region, ioremap. This does not only lead to a lot of code > > duplication, but also a huge number of similar error strings and > > inconsistent error codes on failure. So, introduce a helper function > > which simplifies remapping a resource and make it hard to do something > > wrong and add documentation for it. > > > > Signed-off-by: Wolfram Sang > > Cc: Grant Likely > > Cc: Tejun Heo > > Cc: Greg KH > > Acked-by: Tejun Heo > > Greg, can you please take this one? Ok, I'll queue it up after the 3.2 merge window is over, for the 3.3 release. thanks, greg k-h