From: "Stephen M. Cameron" <scameron@beardog.cce.hp.com>
To: james.bottomley@hansenpartnership.com
Cc: stephenmcameron@gmail.com, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
mikem@beardog.cce.hp.com
Subject: [PATCH 5/5] hpsa: fix flush cache transfer length
Date: Wed, 26 Oct 2011 16:21:17 -0500 [thread overview]
Message-ID: <20111026212117.15570.3563.stgit@beardog.cce.hp.com> (raw)
In-Reply-To: <20111026212006.15570.26229.stgit@beardog.cce.hp.com>
From: Stephen M. Cameron <scameron@beardog.cce.hp.com>
We weren't filling in the transfer length of the
flush cache command (it transfers 4 bytes of zeroes).
Firmware didn't seem to be bothered by this, but it
should be fixed.
Signed-off-by: Stephen M. Cameron <scameron@beardog.cce.hp.com>
---
drivers/scsi/hpsa.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
index 646516f..45477b0 100644
--- a/drivers/scsi/hpsa.c
+++ b/drivers/scsi/hpsa.c
@@ -2876,6 +2876,8 @@ static void fill_cmd(struct CommandList *c, u8 cmd, struct ctlr_info *h,
c->Request.Timeout = 0;
c->Request.CDB[0] = BMIC_WRITE;
c->Request.CDB[6] = BMIC_CACHE_FLUSH;
+ c->Request.CDB[7] = (size >> 8) & 0xFF;
+ c->Request.CDB[8] = size & 0xFF;
break;
case TEST_UNIT_READY:
c->Request.CDBLen = 6;
prev parent reply other threads:[~2011-10-26 21:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-26 21:20 [PATCH 0/5] hpsa: driver updates, Oct 25, 2011 Stephen M. Cameron
2011-10-26 21:20 ` [PATCH 1/5] hpsa: set max sectors instead of taking the default Stephen M. Cameron
2011-10-26 21:20 ` [PATCH 2/5] hpsa: remove unused busy_initializing and busy_scanning Stephen M. Cameron
2011-10-26 21:21 ` [PATCH 3/5] hpsa: rename HPSA_MAX_SCSI_DEVS_PER_HBA Stephen M. Cameron
2011-10-26 21:21 ` [PATCH 4/5] hpsa: fix potential array overflow in hpsa_update_scsi_devices Stephen M. Cameron
2011-10-30 10:16 ` James Bottomley
2011-10-31 14:36 ` scameron
2011-10-26 21:21 ` Stephen M. Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111026212117.15570.3563.stgit@beardog.cce.hp.com \
--to=scameron@beardog.cce.hp.com \
--cc=akpm@linux-foundation.org \
--cc=james.bottomley@hansenpartnership.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mikem@beardog.cce.hp.com \
--cc=stephenmcameron@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.