All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Matthew Piehl <matthew.piehl232@gmail.com>
Cc: gregkh@suse.de, devel@driverdev.osuosl.org, asedeno@mit.edu,
	lucas.demarchi@profusion.mobi, Linux-kernel@vger.kernel.org,
	shemminger@vyatta.com
Subject: Re: [PATCH] staging: bcm: Fixed major coding style issues
Date: Thu, 27 Oct 2011 07:52:23 +0200	[thread overview]
Message-ID: <20111027055223.GB1388@kroah.com> (raw)
In-Reply-To: <1319669560-10979-1-git-send-email-Matthew.Piehl232@gmail.com>

On Wed, Oct 26, 2011 at 05:52:40PM -0500, Matthew Piehl wrote:
> Fixed major coding style issues and removed all checkpatch errors and
> and many warnings.

You just did a whole lot of things all in one patch, making it very hard
to review.

Please break it up into one-patch-per-logical-change, and no, "fix
everything" is not a single logical change :)

Also, please check Linus's current tree to see if this even applies, I
don't want you to do work that's already been done as that would be sad.

thanks,

greg k-h

  reply	other threads:[~2011-10-27  6:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-26 22:52 [PATCH] staging: bcm: Fixed major coding style issues Matthew Piehl
2011-10-27  5:52 ` Greg KH [this message]
2011-11-27  1:08 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111027055223.GB1388@kroah.com \
    --to=greg@kroah.com \
    --cc=Linux-kernel@vger.kernel.org \
    --cc=asedeno@mit.edu \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@suse.de \
    --cc=lucas.demarchi@profusion.mobi \
    --cc=matthew.piehl232@gmail.com \
    --cc=shemminger@vyatta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.