All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tim Deegan <tim@xen.org>
To: Andres Lagar-Cavilla <andres@lagarcavilla.org>
Cc: andres@gridcentric.ca, xen-devel@lists.xensource.com,
	olaf@aepfle.de, keir.xen@gmail.com, adin@gridcentric.ca
Subject: Re: [PATCH 9 of 9] Modify all call sites of queries into the p2m to use the new fine-grained locking
Date: Thu, 27 Oct 2011 16:02:07 +0100	[thread overview]
Message-ID: <20111027150207.GO59656@ocelot.phlegethon.org> (raw)
In-Reply-To: <d13f91c2fe18d58ad27f.1319690034@xdev.gridcentric.ca>

At 00:33 -0400 on 27 Oct (1319675634), Andres Lagar-Cavilla wrote:
>  28 files changed, 519 insertions(+), 101 deletions(-)

And I thought patch 5 was big :)

I'm not going to read the detail of this this time around - I'd like to
only have to review it once. :)  

I wonder whether it would be worth changing the name/signature of the
generic p2m functions in an incompatime way while we're there.  It would
have three advantages:

 - allow the lookup/drop pairs to have nice matching names
 - get rid of the confusingly-named 'gmfn_to_mfn' function 
 - avoid later bugs if patches are forward-ported across this chaneg
   that add p2m lookups (but not corresoponding drops)

Tim.

  reply	other threads:[~2011-10-27 15:02 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-27  4:33 [PATCH 0 of 9] [RFC] p2m fine-grained concurrency control Andres Lagar-Cavilla
2011-10-27  4:33 ` [PATCH 1 of 9] Refactor mm-lock ordering constructs Andres Lagar-Cavilla
2011-10-27  4:33 ` [PATCH 2 of 9] Declare an order-enforcing construct for external locks used in the mm layer Andres Lagar-Cavilla
2011-10-27  4:33 ` [PATCH 3 of 9] Enforce ordering constraints for the page alloc lock in the PoD code Andres Lagar-Cavilla
2011-10-27 13:36   ` Tim Deegan
2011-11-02 13:59     ` andres
2011-11-03 13:49       ` Tim Deegan
2011-10-27  4:33 ` [PATCH 4 of 9] Rework locking in the PoD layer Andres Lagar-Cavilla
2011-10-27 13:55   ` Tim Deegan
2011-11-02 14:04     ` andres
2011-11-02 22:30   ` George Dunlap
2011-11-03 14:57     ` Andres Lagar-Cavilla
2011-10-27  4:33 ` [PATCH 5 of 9] Fine-grained concurrency control structure for the p2m Andres Lagar-Cavilla
2011-10-27 14:43   ` Tim Deegan
2011-11-02 14:20     ` andres
2011-11-03 14:29       ` Tim Deegan
2011-11-03 14:46         ` Andres Lagar-Cavilla
2011-10-27  4:33 ` [PATCH 6 of 9] Protect superpage splitting in implementation-dependent traversals Andres Lagar-Cavilla
2011-10-27  4:33 ` [PATCH 7 of 9] Refactor p2m get_entry accessor Andres Lagar-Cavilla
2011-10-27  4:33 ` [PATCH 8 of 9] Modify all internal p2m functions to use the new fine-grained locking Andres Lagar-Cavilla
2011-10-27 14:57   ` Tim Deegan
2011-11-02 14:24     ` andres
2011-11-03 14:33       ` Tim Deegan
2011-11-03 15:16         ` Andres Lagar-Cavilla
2011-11-02 23:00   ` George Dunlap
2011-11-03 15:14     ` Andres Lagar-Cavilla
2011-10-27  4:33 ` [PATCH 9 of 9] Modify all call sites of queries into the p2m " Andres Lagar-Cavilla
2011-10-27 15:02   ` Tim Deegan [this message]
2011-11-02 14:32     ` andres
2011-11-03 14:38       ` Tim Deegan
2011-11-03 15:20         ` Andres Lagar-Cavilla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111027150207.GO59656@ocelot.phlegethon.org \
    --to=tim@xen.org \
    --cc=adin@gridcentric.ca \
    --cc=andres@gridcentric.ca \
    --cc=andres@lagarcavilla.org \
    --cc=keir.xen@gmail.com \
    --cc=olaf@aepfle.de \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.